Bug 282844
| Summary: | [NEW PORT] www/py-flask-dance: Doing the OAuth dance with style using Flask, requests, and oauthlib | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Wener <matthew> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Dries Michiels <driesm> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | driesm, matthew | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | 282842, 282843 | ||||||||||||
| Bug Blocks: | 281304 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Matthew Wener
2024-11-18 16:07:54 UTC
Created attachment 255276 [details]
New Port py-flask-dance 7.1.0
TEST_IMPLIES doesnt exist. I have made some changes to the Makefile based on portclippy output as well (order of variables in the makefile). Do you mean for TEST_IMPLIES that the dependencies of SQLA14 are added to TEST_DEPENDS? TEST_IMPLIES doesn't exist because TEST is not an option its a target in the framework, make test Created attachment 255327 [details] New Port py-flask-dance 7.1.0 v2 (In reply to Dries Michiels from comment #3) Removed the test implies and added as a test depends. Also changed the port to default to SQL Alchemy 2.0. Originally when I wrote this there was a conflict in version with a dependency, but that conflict has been resolved. I'm a bit confused with the SQLA option. Is a dependency on either SQLA14 or SQLA20 mandatory? If so we need to make the RADIO a SINGLE, and we should add OPTIONS_DEFAULT= either of the two. Because right now because of +DOCS_IMPLIES= SQLA20, it is already acting as a single almost. Given with the default options (DOCS is by default enabled). Can you elaborate? Ideally we toggle the SQLA option for all dependencies, rm we have hardcoded SQL20 for tests, but wen can also add SQL14_TEST_DEPENDS=.. SQL14_TEST_DEPENDS+=.. Created attachment 255366 [details] New Port py-flask-dance 7.1.0 v3 (In reply to Dries Michiels from comment #5) Got it. I changed it to a build dependency as it is required to build the docs, but is considered optional per upstream. (In reply to Dries Michiels from comment #6) So one of the dependencies, www/py-flask-sqlalchemy has a requirement to use SQLA20. Which would end up creating a conflict if this port tries to use SQLA14. Should I just remove the option for SQLA14? (In reply to Matthew Wener from comment #8) Definitely confusing myself. The port itself can be built with SQLA14 or SQLA20. However, the tests have to use SQLA20 because of www/py-flask-sqlalchemy dependency. The DOCS require SQLA14 or SQLA20 to build. Created attachment 255375 [details] New Port py-flask-dance 7.1.0 v4 (In reply to Dries Michiels from comment #6) I added an if statement to determine if DOCS are enabled. If SQLA14 is set the docs will build with SQLA14. If SQLA14 is not set and DOCS are enabled, they will be built with SQLA20 by default. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b8dd0ef9f7193a03cc98a1575bb1a6508c3984bf commit b8dd0ef9f7193a03cc98a1575bb1a6508c3984bf Author: Matthew Wener <matthew@wener.org> AuthorDate: 2024-11-22 06:47:04 +0000 Commit: Dries Michiels <driesm@FreeBSD.org> CommitDate: 2024-11-22 06:55:36 +0000 www/py-flask-dance: add new port Doing the OAuth dance with style using Flask, requests and oauthlib. PR: 282844 www/Makefile | 1 + www/py-flask-dance/Makefile (new) | 87 ++++++++++++++++++++++++++++++++++++++ www/py-flask-dance/distinfo (new) | 3 ++ www/py-flask-dance/pkg-descr (new) | 4 ++ 4 files changed, 95 insertions(+) |
