Bug 282865

Summary: textproc/rxp unbreak and undeprecate by upgrading
Product: Ports & Packages Reporter: Mikhail T. <freebsd-2024>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz
Priority: --- Keywords: easy, patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Upgrade rxp from 1.4.4 to 1.5.2
freebsd-2024: maintainer-approval+
In format-patch format none

Description Mikhail T. 2024-11-19 19:04:11 UTC
Created attachment 255304 [details]
Upgrade rxp from 1.4.4 to 1.5.2

The included patch will upgrade the port -- along with undeprecating it.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-11-19 19:04:11 UTC
Maintainer informed via mail
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-11-20 15:22:41 UTC
Are you the maintainer or is this someone else?
Comment 3 Mikhail T. 2024-11-22 21:30:04 UTC
> Are you the maintainer or is this someone else?

My name is Mikhail Teterin and I approve this mess... err... never mind. Yes, I'm the port's maintainer -- and I already approved the patch, when submitting the PR. Thank you!
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-11-26 12:34:54 UTC
WRKSRC and MAKE_ARGS are no prefixed with dashes.  Is this intentional?  Never seen anything like that before.  If you don't mind, I would go ahead and take these out.

Would it make sense to provide flavours / slave ports for the two char sizes so they can be installed concurrently?

Is there a changelog for this update?
Comment 5 Mikhail T. 2024-11-26 20:18:38 UTC
Created attachment 255474 [details]
In format-patch format
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-11-27 12:02:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=46ee3a64e2c174407a9346ef72676fb865b240d7

commit 46ee3a64e2c174407a9346ef72676fb865b240d7
Author:     Mikhail Teterin <mi@FreeBSD.org>
AuthorDate: 2024-11-26 12:34:32 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-27 11:57:30 +0000

    textproc/rxp: update to 1.5.2 and unbreak

    PR:             282865

 textproc/rxp/Makefile                      |  43 ++---
 textproc/rxp/distinfo                      |   5 +-
 textproc/rxp/files/BSDmakefile.lib (gone)  |  26 ---
 textproc/rxp/files/BSDmakefile.rxp (gone)  |  12 --
 textproc/rxp/files/patch-char-size-8 (new) |  21 ++
 textproc/rxp/files/patch-warnings          | 296 +++++++++++++----------------
 textproc/rxp/pkg-plist                     |   9 +-
 7 files changed, 179 insertions(+), 233 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-11-27 12:04:53 UTC
Thank you for your contribution.