Bug 28288

Summary: IPv6 support isn't #ifdef'd in src/contrib/tcpdump/print-ospf6.c
Product: Base System Reporter: Omachonu Ogali <missnglnk>
Component: miscAssignee: Bill Fenner <fenner>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Omachonu Ogali 2001-06-20 04:30:03 UTC 
	IPv6 support is not checked in src/contrib/tcpdump/print-ospf6.c a 
	la #ifdef as it is in the other print-*6.c files, resulting in
	undefined references.

How-To-Repeat: 	Compile without IPv6 support.
Comment 1 dwmalone freebsd_committer freebsd_triage 2001-06-20 13:47:52 UTC 
State Changed
From-To: open->closed
Comment 2 dwmalone freebsd_committer freebsd_triage 2001-06-20 13:48:17 UTC 
State Changed
From-To: closed->open

Closed accidently. Give PR to Bill Fenner, who's looking after tcpdump.
Comment 3 dwmalone freebsd_committer freebsd_triage 2001-06-20 13:48:17 UTC 
Responsible Changed
From-To: freebsd-bugs->fenner

Bill Fenner looks after tcpdump.
Comment 4 Bill Fenner 2001-06-20 16:34:04 UTC 
Would you try this patch?  tcpdump itself conditionally includes these
sources, which is why there's no ifdef.

Thanks,
  Bill

cvs diff: Diffing .
Index: Makefile
===================================================================
RCS file: /home/ncvs/src/usr.sbin/tcpdump/tcpdump/Makefile,v
retrieving revision 1.30
diff -u -r1.30 Makefile
--- Makefile	2001/04/20 17:30:11	1.30
+++ Makefile	2001/06/20 15:30:37
@@ -8,16 +8,16 @@
 	print-ah.c print-arp.c print-ascii.c print-atalk.c \
 	print-atm.c print-bgp.c print-bootp.c print-bxxp.c \
 	print-cdp.c print-chdlc.c print-cip.c print-cnfp.c \
-	print-decnet.c print-dhcp6.c print-domain.c print-dvmrp.c \
+	print-decnet.c print-domain.c print-dvmrp.c \
 	print-egp.c print-esp.c print-ether.c print-fddi.c \
-	print-frag6.c print-gre.c print-icmp.c print-icmp6.c \
-	print-igmp.c print-igrp.c print-ip.c print-ip6.c \
-	print-ip6opts.c print-ipcomp.c print-ipx.c print-isakmp.c \
+	print-gre.c print-icmp.c \
+	print-igmp.c print-igrp.c print-ip.c \
+	print-ipcomp.c print-ipx.c print-isakmp.c \
 	print-isoclns.c print-krb.c print-l2tp.c print-lane.c \
 	print-lcp.c print-llc.c print-mobile.c print-nfs.c \
-	print-ntp.c print-null.c print-ospf.c print-ospf6.c \
+	print-ntp.c print-null.c print-ospf.c \
 	print-pim.c print-ppp.c print-pppoe.c print-radius.c \
-	print-raw.c print-rip.c print-ripng.c print-rt6.c \
+	print-raw.c print-rip.c \
 	print-rx.c print-sl.c print-sll.c print-smb.c print-snmp.c \
 	print-stp.c print-sunrpc.c print-tcp.c print-telnet.c \
 	print-tftp.c print-timed.c print-token.c print-udp.c \
@@ -28,6 +28,8 @@
 CFLAGS+= -DHAVE_CONFIG_H
 .if !defined(NOINET6)
 CFLAGS+=	-DINET6
+SRCS+=		print-ip6.c print-ip6opts.c print-ripng.c print-icmp6.c \
+		print-frag6.c print-rt6.c print-ospf6.c print-dhcp6.c
 .endif
 
 DPADD+=	${LIBL} ${LIBPCAP}
Comment 5 Omachonu Ogali 2001-06-20 20:16:31 UTC 
On Wed, Jun 20, 2001 at 08:55:54AM -0700, Bill Fenner wrote:
> 
> [My original message bounced, but some really brilliant internal AT&T
> mailer stripped the bounce message so I got an email from your
> mailer-daemon with "<<< MIME ATTACHMENT STRIPPED >>>" -- if you reply,
> please cc freebsd-gnats-submit@freebsd.org on your reply and keep the
> subject the same.  Sorry for the confusion.]
> 
> Would you try this patch?  tcpdump itself conditionally includes these
> sources, which is why there's no ifdef.

Woohoo! I took a look at print-ip6.c and saw it #ifdef'd in there,
didn't know about the Makefile thingy. :)

> Thanks,
>   Bill
> 
> cvs diff: Diffing .
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/tcpdump/tcpdump/Makefile,v
> retrieving revision 1.30
> diff -u -r1.30 Makefile
> --- Makefile	2001/04/20 17:30:11	1.30
> +++ Makefile	2001/06/20 15:30:37
> @@ -8,16 +8,16 @@
>  	print-ah.c print-arp.c print-ascii.c print-atalk.c \
>  	print-atm.c print-bgp.c print-bootp.c print-bxxp.c \
>  	print-cdp.c print-chdlc.c print-cip.c print-cnfp.c \
> -	print-decnet.c print-dhcp6.c print-domain.c print-dvmrp.c \
> +	print-decnet.c print-domain.c print-dvmrp.c \
>  	print-egp.c print-esp.c print-ether.c print-fddi.c \
> -	print-frag6.c print-gre.c print-icmp.c print-icmp6.c \
> -	print-igmp.c print-igrp.c print-ip.c print-ip6.c \
> -	print-ip6opts.c print-ipcomp.c print-ipx.c print-isakmp.c \
> +	print-gre.c print-icmp.c \
> +	print-igmp.c print-igrp.c print-ip.c \
> +	print-ipcomp.c print-ipx.c print-isakmp.c \
>  	print-isoclns.c print-krb.c print-l2tp.c print-lane.c \
>  	print-lcp.c print-llc.c print-mobile.c print-nfs.c \
> -	print-ntp.c print-null.c print-ospf.c print-ospf6.c \
> +	print-ntp.c print-null.c print-ospf.c \
>  	print-pim.c print-ppp.c print-pppoe.c print-radius.c \
> -	print-raw.c print-rip.c print-ripng.c print-rt6.c \
> +	print-raw.c print-rip.c \
>  	print-rx.c print-sl.c print-sll.c print-smb.c print-snmp.c \
>  	print-stp.c print-sunrpc.c print-tcp.c print-telnet.c \
>  	print-tftp.c print-timed.c print-token.c print-udp.c \
> @@ -28,6 +28,8 @@
>  CFLAGS+= -DHAVE_CONFIG_H
>  .if !defined(NOINET6)
>  CFLAGS+=	-DINET6
> +SRCS+=		print-ip6.c print-ip6opts.c print-ripng.c print-icmp6.c \
> +		print-frag6.c print-rt6.c print-ospf6.c print-dhcp6.c
>  .endif
>  
>  DPADD+=	${LIBL} ${LIBPCAP}
> 
> 
> 

-- 
Omachonu Ogali
missnglnk@informationwave.net
http://www.informationwave.net
Comment 6 Bill Fenner freebsd_committer freebsd_triage 2001-07-11 22:46:31 UTC 
State Changed
From-To: open->closed

Fixed in rev 1.31 of src/usr.sbin/tcpdump/tcpdump/Makefile