Bug 282938

Summary: databases/mdbtools: Build with newer versions of LLMV/Clang and improve port
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Rainer Hurling <rhurlin>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (rhurlin)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for mdbtools none

Description Daniel Engberg freebsd_committer freebsd_triage 2024-11-23 20:16:48 UTC
Created attachment 255414 [details]
Patch for mdbtools

* Import patch from macports repo
* Improve Makefile for readability

Source:
https://github.com/macports/macports-ports/blob/master/databases/mdbtools/files/disable-Werror.patch

Builds on 13.4-RELEASE (amd64) and 14.1-RELEASE (amd64)
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-11-24 09:44:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e94112fafcaeaed1360771e68e89e355b2fa11da

commit e94112fafcaeaed1360771e68e89e355b2fa11da
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-11-24 08:54:10 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2024-11-24 09:42:41 +0000

    databases/mdbtools: Allow newer LLMV/Clang

    - Import patch from macports repo
    - Improve Makefile for readability
    - Bump PORTVERSION because of different pkg size

    PR:             282938

    MFH:            2024Q4

 databases/mdbtools/Makefile                    | 25 +++++++------------------
 databases/mdbtools/files/patch-configure (new) | 11 +++++++++++
 2 files changed, 18 insertions(+), 18 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-24 09:45:37 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ab3dadd75864acd2b9660c68a7bb2e4ab991a510

commit ab3dadd75864acd2b9660c68a7bb2e4ab991a510
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-11-24 08:54:10 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2024-11-24 09:44:27 +0000

    databases/mdbtools: Allow newer LLMV/Clang

    - Import patch from macports repo
    - Improve Makefile for readability
    - Bump PORTVERSION because of different pkg size

    PR:             282938

    MFH:            2024Q4
    (cherry picked from commit e94112fafcaeaed1360771e68e89e355b2fa11da)

 databases/mdbtools/Makefile                    | 25 +++++++------------------
 databases/mdbtools/files/patch-configure (new) | 11 +++++++++++
 2 files changed, 18 insertions(+), 18 deletions(-)
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2024-11-24 10:05:57 UTC
Hi Daniel,
Many thanks for the patch. I was not aware of the macports patch, and nice to get rid of the constraint on certain clang versions :)

To pet portclippy, I moved CONFIGURE_ARGS again. I also increased PORTVERSION because the pkg size has changed.

Committed in main and 2024Q4, as it is more of a fix.

Also testet on 14.2-STABLE (i386).