Bug 283062
| Summary: | net/teddycloud | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michael Pape <freebsd> | ||||
| Component: | Individual Port(s) | Assignee: | Zsolt Udvari <uzsolt> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | fuz, uzsolt | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | i386 | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284350 | ||||||
| Attachments: |
|
||||||
Committed, thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b59ef9c848dec05396438fe1c0f9bcdc97bf6d6d commit b59ef9c848dec05396438fe1c0f9bcdc97bf6d6d Author: Michael Pape <freebsd@pe82.de> AuthorDate: 2024-12-01 20:30:42 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-12-01 20:32:10 +0000 net/teddycloud: Ignore i386 Does fail to build on i386 targets, ignore this arch. Replace space characters to tabs. PR: 283062 Approved by: submitter is maintainer net/teddycloud/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) If a port fails on an architecture but should work with fixes, the correct course of action is to set the architecture as BROKEN. NOT_FOR_ARCHS means “doesn't work and isn't meant to work.” BROKEN means “doesn't work, but could be fixed.” (In reply to Robert Clausecker from comment #3) The project itself only offers x64 builds in its releases, so I assumed they don't intend to support x86. One could argue that C code should generally be patchable to support x86, but still I'm not confident if BROKEN would be the correct representation of that. (In reply to Michael Pape from comment #4) That's okay, but then the reason is “not supported by upstream,” not “does not build.” If you update this port, please add a NOT_FOR_ARCHS_REASON to explain that this is the case. Please also add armv7 as an architecture this port does not build on. You would have saved me about an hour of investigating the armv7 build failure if the port had immediately said that 32 bit architectures are not supported. (In reply to Robert Clausecker from comment #5) Sorry for causing you any trouble. I'll create a fix. |
Created attachment 255560 [details] Patch to ignore i386 Does fail to build on i386 targets. Since I don't have a target to test it on, I'd like to ignore i386 for the time being.