Bug 283070
| Summary: | math/mprime: Update to 30.19b21 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | takefu | ||||
| Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | fuz, rozhuk.im | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(rozhuk.im) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
(In reply to takefu from comment #0) Thanks, LGTM. i386 can be fixed, but some one should write bug report to mprime authors or provide path :) I'll remove the ${DUMMY} from the Makefile.
Portlint is wrong with this complaint and having ${DUMMY} there makes the error message harder to understand.
Note that you can handle the various i386 / amd64 distinctions in a more declarative manner like so:
ALL_TARGET_amd64= makebsd64
ALL_TARGET_i386= makemsys
ALL_TARGET= ${ALL_TARGET_${ARCH}}
I'll commit the patch as is, but do check this for the next update.
And please submit patches in git-format-patch format if possible.
Is there a changelog for this update?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e1e35b6cb7dd95e9bb1f199370341f6349c60a44 commit e1e35b6cb7dd95e9bb1f199370341f6349c60a44 Author: takefu <takefu@airport.fm> AuthorDate: 2024-12-09 14:13:45 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-12-10 09:05:40 +0000 math/mprime: update to 30.19b21 PR: 283070 Approved by: rozhuk.im@gmail.com (maintainer) math/mprime/Makefile | 30 ++++++++++-------------------- math/mprime/distinfo | 6 +++--- 2 files changed, 13 insertions(+), 23 deletions(-) Thank you for your contribution. (In reply to Robert Clausecker from comment #2) Thank you for the commit. Portlint (1) If there is a problem with the execution result, please let me know. All_target_* This writing is easy to see. Git-format-patch does not understand. Changelog is not the latest version of the web on the web. :-p (In reply to takefu from comment #5) portlint issues a warning for your port: WARN: Makefile: possible use of absolute pathname "/gwnum/polymult.a" This warning does not indicate an error; /gwnum/polymult.a is part of the error message you cite, not an absolute path you install files to. So it's not correct and should be ignored. > Git-format-patch does not understand. Clone the ports tree git repository. Make your changes, then commit them. Run "git format-patch" to produce a patch file based on the commit. Upload this patch file to Bugzilla. This is the preferred way to submit contributions to Bugzilla. |
Created attachment 255575 [details] mprime-30.19b21.patch portlint(1) Compliant. I replaced the IF syntax of Makefile, but it is not necessary in the future because the i386 is broken. :-)