Bug 283148
| Summary: | www/webtrees20: mark deprecated and set expiration_date | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Krzysztof <ports> | ||||
| Component: | Individual Port(s) | Assignee: | Zsolt Udvari <uzsolt> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | uzsolt | ||||
| Priority: | --- | Flags: | ports:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283149 | ||||||
| Attachments: |
|
||||||
IMHO you should refactor the webtrees* ports. As I see on web page (https://webtrees.net/install/) the webtrees21 branch is for php74-php82, the webtrees22 is for php83-php84. I suggest php-flavors (https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-auto-php-app) and using IGNORE_WITH_PHP (https://docs.freebsd.org/en/books/porters-handbook/book/#uses-php-ignore). What do you think? (In reply to Zsolt Udvari from comment #1) Yes, you are right. I should add IGNORE_WITH_PHP So I will make new patches. OK, So I have "show stopper" :-)
currently (new) Makefile looks like this:
[...]
PKGNAMESUFFIX= 21 # (or 22 for new port)
[...]
WWWDIR= ${PREFIX}/www/webtrees${PKGNAMESUFFIX}
DOCSDIR= ${PREFIX}/share/doc/webtrees${PKGNAMESUFFIX}
with php-flavors it could be like this:
PKGNAMESUFFIX= 21${PHP_PKGNAMESUFFIX}
and how to "automate" these variables?
WWWDIR= ${PREFIX}/www/webtrees${PKGNAMESUFFIX}
DOCSDIR= ${PREFIX}/share/doc/webtrees${PKGNAMESUFFIX}
Maybe I can use/set VERSION_SUFFIX?
Maybe my question is very stupid, but I'm (still) begginer as port maintainer :-)))
Thanks a lot for any suggestions.
(In reply to Krzysztof from comment #3) Maybe I can use "custom variables" in Makefile? (In reply to Krzysztof from comment #4) You don't need use custom variables (only in rare cases). You can see a similar example in devel/phpunit* ports. The WWWDIR is /usr/local/www/phpunit/ without any suffix (can check with 'make -V WWWDIR'). Every phpunit* ports conflict another phpunit* ports so the /usr/local/www/phpunit/ directory is used only by one port. If you've questions please ask! (In reply to Zsolt Udvari from comment #5) OK, thanks a lot for any hints. I'm still thinking about howto avoid conflicts... As you can see there is such definition: SUB_LIST= VERSION_SUFFIX=${PKGNAMESUFFIX} VERSION_SUFFIX variable is then "used" in pkg-message.in. I've made a grep across whole ports tree and I did not find explicite declaration, but maybe it will be correct to define in Makefile: VERSION_SUFFIX=21 [...] WWWDIR= ${PREFIX}/www/webtrees${VERSION_SUFFIX} SUB_LIST= VERSION_SUFFIX=${VERSION_SUFFIX} [...] or new Makefile will look like current: [...] DOCSDIR= ${PREFIX}/share/doc/webtrees21 Sorry, I forgot to commit it. But now is committed, thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0fdf2e8cbf13f3042f1c75552125cc59c769a658 commit 0fdf2e8cbf13f3042f1c75552125cc59c769a658 Author: Krzysztof <ports@bsdserwis.com> AuthorDate: 2024-12-27 18:38:10 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-12-27 18:38:10 +0000 www/webtrees20: Mark deprecated and set expiration_date PR: 283148 Approved by: submitter is maintainer www/webtrees20/Makefile | 3 +++ 1 file changed, 3 insertions(+) |
Created attachment 255645 [details] patch to set expiration date www/webtrees20 should be set as deprecated because it depens on obsolete php version (php7x). Also I suggest adding such entry to MOVED: www/webtrees20|www/webtrees21|2023-12-31|Obsolete - use webtrees21 instead