Bug 283162

Summary: news/nzbget: Update to 24.4
Product: Ports & Packages Reporter: Alex Levy <a13xlevy>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: fuz
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to update nzbget to v24.4
none
Patch to update nzbget to v24.4
none
Patch to update nzbget to v24.4
none
Patch to update nzbget to v24.4 none

Description Alex Levy 2024-12-06 11:17:35 UTC 
Created attachment 255663 [details]
Patch to update nzbget to v24.4

Update news/nzbget to 24.4

Release notes available at https://github.com/nzbgetcom/nzbget/releases/tag/v24.4

Notable changes that modifies the way to port is built:

* Dependency to PAR2 is now coming from another repository that needs to be fetched separately (see comments in Makefile for more details)
* Patch cmake/posix.cmake to unset CURSES_NEED_WIDE as it seems not to be exposed as a configure option by ncurses port
Comment 1 Alex Levy 2024-12-06 13:51:07 UTC 
Created attachment 255666 [details]
Patch to update nzbget to v24.4

Removed unnecessary python:build use
Comment 2 Alex Levy 2024-12-06 16:48:45 UTC 
Created attachment 255667 [details]
Patch to update nzbget to v24.4

Add python option (only required to run nzbget extensions)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-12-09 11:30:11 UTC 
Please remember to clear PORTREVISION when updating DISTVERSION.

I recommend using GH_TUPLE for additional distfiles, though the way you do it is ok, too.

PYTHON_DESC is not a good option description as it doesn't say what the option does.  Perhaps leave PYTHON_DESC as the default and instead add a pkg-help file.  This file can be opened as on-line help when configuring the port's options.

Please use @sample for the configuration file, see Porter's Handbook for details.

Why do you install the par2 libraries with the port?  This port is news/nzbget, not news/par2.  It doesn't seem sensible to install static bundled libraries with the port.  Long term consider submitting the forked par2 library as a port on its own so it can be unbundled.

Please check and resubmit.
Comment 4 Alex Levy 2024-12-16 10:34:10 UTC 
Created attachment 255887 [details]
Patch to update nzbget to v24.4

Thanks for the feedback. I've applied the suggestions. Could you please check again ?

Many thanks.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-12-16 19:38:12 UTC 
It's better though I'll truncate PAR2_DESC.  It's too long to fit the ports configuration dialog.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-12-17 00:59:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=545eb5d3ac42b28ec59eb579307f8ec414234af4

commit 545eb5d3ac42b28ec59eb579307f8ec414234af4
Author:     Alexandre Levy <a13xlevy@pm.me>
AuthorDate: 2024-12-06 11:11:29 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-17 00:57:23 +0000

    news/nzbget: Upgrade to v24.4

    Release notes available at https://github.com/nzbgetcom/nzbget/releases/tag/v24.4

    Notable changes that modifies the way to port is built:

    * Dependency to PAR2 is now coming from another repository that needs to
      be fetched separately (see comments in Makefile for more details)
    * Patch cmake/posix.cmake to unset CURSES_NEED_WIDE as it seems not to
      be exposed as a configure option by ncurses port

    PR:             283162

 news/nzbget/Makefile                            | 40 ++++++++++++++++++-------
 news/nzbget/distinfo                            |  8 +++--
 news/nzbget/files/patch-cmake_posix.cmake (new) | 10 +++++++
 news/nzbget/pkg-help (new)                      |  9 ++++++
 news/nzbget/pkg-plist                           |  3 +-
 5 files changed, 55 insertions(+), 15 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-12-17 01:04:15 UTC 
Thank you for your contribution.