Bug 283184
| Summary: | net/uriparser: Utilize framework for unit tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Daniel Engberg <diizzy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | svysh.fbsd | ||||
| Priority: | --- | Flags: | svysh.fbsd:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Daniel, As far as I can see, both old and new approaches to run tests work just fine here. If you prefer the new one, this patch is ok with me. But to be on a safe side, can I ask to retain a version check like this: TEST_DEPENDS= googletest>=1.10.0:devel/googletest instead of yours: TEST_DEPENDS= googletest>0:devel/googletest Regards, Sergei (as a maintainer) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=197b5473c2c2f1e899dd234f6f9a76307e89453b commit 197b5473c2c2f1e899dd234f6f9a76307e89453b Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-12-10 19:15:14 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-12-10 19:40:05 +0000 net/uriparser: Utilize framework for unit tests Instead of having unit tests as an option and enabled by default build when requested. PR: 283184 Reviewed by: Sergei Vyshenski <svysh.fbsd@gmail.com> (maintainer) net/uriparser/Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) Committed, thanks! |
Created attachment 255685 [details] Patch for uriparser Instead of having tests as an option and enabled by default build everything on demand