Bug 283489

Summary: emulators/flycast: unbreak build after graphics/glslang 15.1.0_1 update
Product: Ports & Packages Reporter: Stefan Schlosser <bsdcode>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: jbeich
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://pkg-status.freebsd.org/beefy22/data/141amd64-default/e0765bd8fdc4/logs/flycast-2.4_1.log
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283325
Bug Depends on:    
Bug Blocks: 283325    
Attachments:
Description Flags
unbreak build bsdcode: maintainer-approval+

Description Stefan Schlosser 2024-12-22 10:19:18 UTC
Created attachment 256041 [details]
unbreak build

After the update of graphics/glslang to 15.1.0_1 (see PR 283325), the build
fails at configuration stage by not finding the FindSPIRV-Tools-opt.cmake module.
Unbreak the build by adding graphics/spirv-tools to the BUILD_DEPENDS list when
building with vulkan support.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-12-23 23:05:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8de81f83be09343d77ac5ee84ab8641cd72a244d

commit 8de81f83be09343d77ac5ee84ab8641cd72a244d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-12-23 21:05:37 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-12-23 23:03:09 +0000

    graphics/glslang: track static library dependency after cbf133ac4b4a

    $ cat CMakeLists.txt
    cmake_minimum_required(VERSION 3.10)
    project(foo)
    find_package(glslang REQUIRED)

    $ cmake .
    [...]
    CMake Error at /usr/local/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
      By not providing "FindSPIRV-Tools-opt.cmake" in CMAKE_MODULE_PATH this
      project has asked CMake to find a package configuration file provided by
      "SPIRV-Tools-opt", but CMake did not find one.

      Could not find a package configuration file provided by "SPIRV-Tools-opt"
      with any of the following names:

        SPIRV-Tools-optConfig.cmake
        spirv-tools-opt-config.cmake

      Add the installation prefix of "SPIRV-Tools-opt" to CMAKE_PREFIX_PATH or
      set "SPIRV-Tools-opt_DIR" to a directory containing one of the above files.
      If "SPIRV-Tools-opt" provides a separate development package or SDK, be
      sure it has been installed.
    Call Stack (most recent call first):
      /usr/local/lib/cmake/glslang/glslang-config.cmake:28 (find_dependency)
      CMakeLists.txt:3 (find_package)

    https://github.com/KhronosGroup/glslang/commit/82e0d00b32d2

    PR:             283489
    Reported by:    Stefan Schlosser

 graphics/glslang/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2024-12-23 23:23:49 UTC
graphics/libplacebo was also affected but masked by an unrelated BROKEN until ports 5dc9e6d0c83c.
Comment 3 Stefan Schlosser 2024-12-23 23:31:30 UTC
Thank you very much for looking into it.