Bug 283976

Summary: devel/doxygen in ports branch 2025Q1 fails in patch phase
Product: Ports & Packages Reporter: Dennis Clarke <dclarke>
Component: Individual Port(s)Assignee: Dima Panov <fluffy>
Status: Closed FIXED    
Severity: Affects Many People CC: diizzy, mandree, sergey.koupreyenko, tijl
Priority: --- Flags: bugzilla: maintainer-feedback? (fluffy)
Version: Latest   
Hardware: amd64   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259331
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283993

Description Dennis Clarke 2025-01-10 09:54:59 UTC 
The log of the fail is not too large and seems to be a patch problem :

=======================<phase: extract        >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  License GPLv2 accepted by the user
===> Fetching all distfiles required by doxygen-1.9.6_1,2 for building
===>  Extracting for doxygen-1.9.6_1,2
=> SHA256 Checksum OK for doxygen-1.9.6.src.tar.gz.
===========================================================================
=======================<phase: patch-depends  >============================
===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0
===========================================================================
=======================<phase: patch          >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Patching for doxygen-1.9.6_1,2
===>   Converting DOS text files to UNIX text files
===>  Applying FreeBSD patches for doxygen-1.9.6_1,2 from /usr/ports/devel/doxygen/files
No file to patch.  Skipping...
1 out of 1 hunks ignored--saving rejects to TinyDeflate/gunzip.hh.rej
Can't create TinyDeflate/gunzip.hh.rej, output is in /tmp/patchrCiluBpK5Qu: No such file or directory
===>  FAILED Applying FreeBSD patch-TinyDeflate_gunzip.hh
===> Cleanly applied FreeBSD patch(es)  patch-CMakeLists.txt
===> FAILED to apply cleanly FreeBSD patch(es)  patch-TinyDeflate_gunzip.hh
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/doxygen
=>> Cleaning up wrkdir
===>  Cleaning for doxygen-1.9.6_1,2
build of devel/doxygen | doxygen-1.9.6_1,2 ended at Fri Jan 10 09:47:21 UTC 2025
build time: 00:00:04
!!! build failure encountered !!!

Seems to be a problem for 13.4-RELEASE-p2 from the ports branch 2025Q1.

This blocks a whole pile of packages for something like KDE5.
Comment 1 Dennis Clarke 2025-01-10 11:16:28 UTC 
Just for the record a grand whopping 220 packages are skipped
due to devel/doxygen doxygen-1.9.6_1,2 patch patch 3
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2025-01-11 10:19:05 UTC 
Seems that 2025Q1 missed 299bcfac7144 - which was written in June 2024, but committed to main after the branch, so I believed these were part of 2025Q1 when doing the MFH.

| devel/doxygen: Add upstream patches to support compressed PDF files
| generated by more recent versions of cairo.

These were actually the ones breaking the Doxygen build with clang-19, without the incremental TinyDeflate patch I've added.

It would seem that there is no reason to withhold those Doxygen patches from the quarterly branch, but that's for tijl@ and fluffy@ to decide.

In the meanwhile, I will revert the breaking change from 2025Q1.
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2025-01-11 10:21:40 UTC 
See also: comment #6 of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259331 which triggered this. My bad.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-11 10:23:05 UTC 
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6887fc0a91ea8dbf56d26babfb8d0ca6a39c5965

commit 6887fc0a91ea8dbf56d26babfb8d0ca6a39c5965
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2025-01-11 10:17:24 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-01-11 10:22:03 +0000

    devel/doxygen: Revert "Fix TinyDeflate's clang-19 compatibility"

    This reverts commit 3cf80a2187c4855c9b4af644c39e82db8321b10e,
    which depended on 299bcfac7144, and the latter has not yet been merged
    onto 2025Q1 (it was authored in June 2024, but only merged after the
    2025Q1 branch, which confused me when cherry-picking 3cf80a2).

    PR:             283976
    Reported by:    Dennis Clarke <dclarke@blastwave.org>

 .../files/patch-TinyDeflate_gunzip.hh (gone)       | 37 ----------------------
 1 file changed, 37 deletions(-)
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2025-01-11 13:07:53 UTC 
*** Bug 283974 has been marked as a duplicate of this bug. ***