Bug 28462

Summary: pkg-install script for perl5.6.1 references 5.6.0 directory
Product: Ports & Packages Reporter: Vivek Khera <khera>
Component: Individual Port(s)Assignee: Anton Berezin <tobez>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Vivek Khera 2001-06-27 20:40:02 UTC 
the pkg-install file references 5.6.0 instead of 5.6.1.

Also, wouldn't it be better if the PERL_VER value was set before
PORTVERSION uses it?

Fix: patch:
Comment 1 Anton Berezin 2001-06-27 22:53:25 UTC 
On Wed, Jun 27, 2001 at 03:37:03PM -0400, khera@kciLink.com wrote:

> >Synopsis:       pkg-install script for perl5.6.1 references 5.6.0 directory

> the pkg-install file references 5.6.0 instead of 5.6.1.

Makes sense, thanks!

> Also, wouldn't it be better if the PERL_VER value was set before
> PORTVERSION uses it?

Umm, no, it's not like make(1) works.  The real problem is the fact that
bsd.port.mk sets PERL_VER unconditionally.  I would say that it does the
right thing - it is not unreasonable to expect that the person who will
dare to override the forbidden port will modify the bsd.port.mk
accordingly.

> >Fix:
> 
> patch:
> 
> --- #pkg-install~	Wed Jun 27 15:22:38 2001
> +++ pkg-install	Wed Jun 27 15:22:38 2001
> @@ -6,7 +6,7 @@
>  
>  INCLUDEDIR=/usr/include
>  
> -install -d ${PREFIX}/lib/perl5/site_perl/5.6.0/arch
> +install -d ${PREFIX}/lib/perl5/site_perl/5.6.1/arch
>  cd ${INCLUDEDIR} && ${PREFIX}/bin/h2ph *.h machine/*.h sys/*.h

Cheers,
+Anton.
-- 
May the tuna salad be with you.
Comment 2 Anton Berezin freebsd_committer freebsd_triage 2001-06-27 22:53:58 UTC 
Responsible Changed
From-To: freebsd-ports->tobez

tobez is the maintainer of this port.
Comment 3 Anton Berezin 2001-06-27 23:04:39 UTC 
On Wed, Jun 27, 2001 at 03:00:19PM -0700, Anton Berezin wrote:

>  > Also, wouldn't it be better if the PERL_VER value was set before
>  > PORTVERSION uses it?
>  
>  Umm, no, it's not like make(1) works.  The real problem is the fact
>  that bsd.port.mk sets PERL_VER unconditionally.  I would say that it
>  does the right thing - it is not unreasonable to expect that the
>  person who will dare to override the forbidden port will modify the
>  bsd.port.mk accordingly.

Following up to my own post...  Argh.

The port Makefile even has a comment to this effect:

   # This will need to be "fixed" in ../../Mk/bsd.port.mk as well.

\Anton.
-- 
May the tuna salad be with you.
Comment 4 Anton Berezin freebsd_committer freebsd_triage 2001-06-29 17:39:49 UTC 
State Changed
From-To: open->closed

Fix committed, thanks!