Bug 28628

Summary:

small indentation change to /sys/kern/kern_sysctl.c

Product:

Base System

Reporter:

Giorgos Keramidas <keramida>

Component:

kern

Assignee:

freebsd-bugs (Nobody) <bugs>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

5.0-CURRENT

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Giorgos Keramidas 2001-07-02 12:20:01 UTC

	Minor indentation change to make things look a little better.
	The call to suser_xxx() is wrapped, but the wrapped line is
	column-aligned with the rest of the conditions of an if ().

How-To-Repeat: 
	Fire up an editor on revision 1.110 of sys/kern/kern_sysctl.c

Comment 1 dima 2001-07-02 23:55:52 UTC

Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> Index: kern_sysctl.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/kern_sysctl.c,v
> retrieving revision 1.110
> diff -c -t -r1.110 kern_sysctl.c
> *** kern_sysctl.c	2001/06/22 19:54:38	1.110
> --- kern_sysctl.c	2001/07/02 09:11:51
> ***************
> *** 1027,1033 ****
>           if (!(oid->oid_kind & CTLFLAG_ANYBODY) &&
>               req->newptr && req->p &&
>               (error = suser_xxx(0, req->p, 
> !             (oid->oid_kind & CTLFLAG_PRISON) ? PRISON_ROOT : 0)))
>                   return (error);
>   
>           if (!oid->oid_handler)
> --- 1027,1034 ----
>           if (!(oid->oid_kind & CTLFLAG_ANYBODY) &&
>               req->newptr && req->p &&
>               (error = suser_xxx(0, req->p, 
> !                          (oid->oid_kind & CTLFLAG_PRISON) ?  PRISON_ROOT : 0)))
> ! 
>                   return (error);

This change introduces two style bugs: (1) secondary indents are four,
not eight spaces, and (2) lines should be <= 80 characters.
Obviously, fixing (1) will fix (2) as well.  That said, I don't think
it makes sense to file PRs for minor style fixes.  There are a lot
more places in the tree where more serious violations are made, and
not only would it take you a long time to find and fix all of them,
I'm not sure anybody would want to commit them for you; it's just too
much trouble for too little gain.

					Dima Dorfman
					dima@unixfreak.org

Comment 2 Bruce Evans 2001-07-03 09:39:18 UTC

On Mon, 2 Jul 2001, Dima Dorfman wrote:

>  Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
>  > Index: kern_sysctl.c
>  > ===================================================================
>  > RCS file: /home/ncvs/src/sys/kern/kern_sysctl.c,v
>  > retrieving revision 1.110
>  > diff -c -t -r1.110 kern_sysctl.c
>  > *** kern_sysctl.c	2001/06/22 19:54:38	1.110
>  > --- kern_sysctl.c	2001/07/02 09:11:51
>  > ***************
>  > *** 1027,1033 ****
>  >           if (!(oid->oid_kind & CTLFLAG_ANYBODY) &&
>  >               req->newptr && req->p &&
>  >               (error = suser_xxx(0, req->p, 
>  > !             (oid->oid_kind & CTLFLAG_PRISON) ? PRISON_ROOT : 0)))
>  >                   return (error);
>  >   
>  >           if (!oid->oid_handler)
>  > --- 1027,1034 ----
>  >           if (!(oid->oid_kind & CTLFLAG_ANYBODY) &&
>  >               req->newptr && req->p &&
>  >               (error = suser_xxx(0, req->p, 
>  > !                          (oid->oid_kind & CTLFLAG_PRISON) ?  PRISON_ROOT : 0)))
>  > ! 
>  >                   return (error);
>  
>  This change introduces two style bugs: (1) secondary indents are four,
>  not eight spaces, and (2) lines should be <= 80 characters.
>  Obviously, fixing (1) will fix (2) as well.

The fix is null since the secondary indent is already 4.  This gives
code that is not very easy to read in this case, especially if you are
not used to the secondary indent rule, but the alternatives are not much
better.

>  That said, I don't think
>  it makes sense to file PRs for minor style fixes.  There are a lot

I agree.

Bruce

Comment 3 Mike Barcroft freebsd_committer

2001-08-02 03:23:33 UTC

State Changed
From-To: open->closed


This type of change would only serve to break style(9).