Bug 287329
| Summary: | x11/xcb-util-cursor update to 0.1.5 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jesper Schmitz Mouridsen <jsm> | ||||||
| Component: | Individual Port(s) | Assignee: | Jesper Schmitz Mouridsen <jsm> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | diizzy, imp, manu, vvd | ||||||
| Priority: | --- | Flags: | manu:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 280573 | ||||||||
| Attachments: |
|
||||||||
"EXTRACT_SUFX=.tar.xz" => "USES=tar:xz"? Created attachment 261036 [details]
EXTRACT_SFX -> USES tar:xz
Before:
Function "cursor_path" not defined.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (cursor_path) pending.
(gdb) r
Starting program: /usr/home/jesper/cursortest6
[New LWP 109597 of process 66386]
[New LWP 109598 of process 66386]
Loaded themed cursor: hand1
Thread 1 hit Breakpoint 1, cursor_path (c=0x8034106e0) at load_cursor.c:48
48 if (c->path == NULL) {
(gdb) n
49 c->path = getenv("XCURSOR_PATH");
(gdb) n
50 if (c->path == NULL)
(gdb) n
51 c->path = XCURSORPATH;
(gdb) n
52 }
(gdb) print c->path
$1 = 0x8031c0ea0 "~/.icons:/usr/share/icons:/usr/share/pixmaps:/usr/X11R6/lib/X11/icons"
After:
Reading symbols from ./cursortest6...
(gdb) b cursor_path
Function "cursor_path" not defined.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (cursor_path) pending.
(gdb) r
Starting program: /usr/home/jesper/cursortest6
[New LWP 109816 of process 69865]
[New LWP 109817 of process 69865]
Loaded themed cursor: hand1
Thread 1 hit Breakpoint 1, cursor_path (c=0x8034106e0) at load_cursor.c:55
55 if (c->path == NULL) {
(gdb) n
56 c->path = getenv("XCURSOR_PATH");
(gdb) n
57 if (c->path == NULL)
(gdb) n
58 c->path = XCURSORPATH;
(gdb) n
59 }
(gdb) print c->path
$1 = 0x8031c0bf1 "~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr/local/share/pixmaps"
[17:13] bsdimp: x11 has stated that you don't even need to wait for the timeout period if it's been built and tested. AFAIU, you can commit it with "Approved by: x11 (maintainer, implicit)". (In reply to Vladimir Druzenko from comment #3) Since I'm the only one in x11@ I'm surprised by this statement as I've never said that. (In reply to Emmanuel Vadot from comment #4) Hm… Sorry for spreading false information. It was just copy&paste. Offtopic: I'm thinking of doing these PR: https://bugs.freebsd.org/bugzilla/buglist.cgi?bug_status=__open__&email2=mew14930xvi%40inbox.lv&emailreporter2=1&short_desc=x11%2F&short_desc_type=allwordssubstr (In reply to Vladimir Druzenko from comment #5) I need to find some time to review all those but if you could take a look at some that would be great. For all the update pkg-descr if the patch is fine you have my blessing to commit them. (In reply to Emmanuel Vadot from comment #6) There was an announcement (mail) on 2023-08-10 "Opening the gates on x11@ ports x11@ is looking for more people to help maintain its ports. Most of the xorg ecosystem is in a maintenance phase, which does not require the restrictive maintainership clause of the past. So if you see an x11@ port that is out of date, or see an improvement that could be made to it, please prepare a patch and give x11@ a heads-up of the upcoming change. If you don't here anything negative back within a week, please feel free to land it with an implicit approval." (In reply to Daniel Engberg from comment #7) Which isn't the same as what imp@ allegedly said. I did say it, but I conveyed the wrong meaning, so go with the email, not the imperfect recollection of the email... (In reply to Warner Losh from comment #9) Or even further, newer modifications that manu@ wants. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4d324d9bf862933182f776073cc5c215b417f578 commit 4d324d9bf862933182f776073cc5c215b417f578 Author: Jesper Schmitz Mouridsen <jsm@FreeBSD.org> AuthorDate: 2025-06-27 19:10:19 +0000 Commit: Jesper Schmitz Mouridsen <jsm@FreeBSD.org> CommitDate: 2025-06-27 19:12:22 +0000 x11/xcb-util-cursor: Update to 0.1.5 Add an upstream patch which corrects default CURSORPATH. Add autoreconf since upstream used aclocal-1.16 PR: 287329 Approved by: manu (maintainer) x11/xcb-util-cursor/Makefile | 8 ++++---- x11/xcb-util-cursor/distinfo | 8 +++++--- .../files/patch-cursor__shape_to_id.gperf (gone) | 18 ------------------ x11/xcb-util-cursor/files/patch-cursor_cursor.h (gone) | 11 ----------- 4 files changed, 9 insertions(+), 36 deletions(-) Close? |
Created attachment 261014 [details] update to 0.1.5 Update to 0.1.5 Add an upstream patch which corrects default CURSORPATH. Add autoreconf since upstream used aclocal-1.16