Bug 29384

Summary: ipfstat picks wrong headers
Product: Base System Reporter: Thomas Quinot <thomas>
Component: binAssignee: jlemon
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.3-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Thomas Quinot 2001-08-02 12:00:04 UTC 
	ipfstat picks some ipfilter headers from /usr/include/netinet
	instead of /sys/contrib/ipfilter/netinet/. When the ipfilter
	structures are changed, this causes an inconsistence between
	the kernel ipfilter and the ipfstat binary.

Fix: In src/sbin/ipfstat:
How-To-Repeat: /usr/src/sbin/ipfstat # cc -O2 -pipe  -DIPL_NAME=\"/dev/ipl\" -DSTATETOP -I- -I/usr/src/sbin/ipfstat/../../sys/netinet -I/usr/src/sbin/ipfstat/../../sys -I/usr/src/sbin/ipfstat/../../contrib/ipfilter -E /usr/src/sbin/ipfstat/../../contrib/ipfilter/fils.c

(will pick headers from /usr/include/netinet/)
Comment 1 dwmalone freebsd_committer freebsd_triage 2001-08-02 13:35:52 UTC 
Responsible Changed
From-To: freebsd-bugs->jlemon

jlemon relocated ipf. 

Jonathan - this patch looks sensible to me.
Comment 2 jlemon freebsd_committer freebsd_triage 2001-09-02 20:30:02 UTC 
State Changed
From-To: open->closed

Fixed in rev 1.12; thanks!
Comment 3 Thomas Quinot 2001-09-03 17:05:22 UTC 
Le 2001-09-02, jlemon@FreeBSD.org écrivait :

> Fixed in rev 1.12; thanks!

I'm afraid not. fils.c #includes "netinet/ip_nat.h"
but 1.12 adds a -I for /sys/contrib/ipfilter/netinet/.
whereas /sys/contrib/ipfilter/ would be needed.

-- 
    Thomas.Quinot@Cuivre.FR.EU.ORG