Bug 295290
| Summary: | cad/gspiceui: Fix documentation path | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kevin Zheng <kevinz5000> | ||||||
| Component: | Individual Port(s) | Assignee: | Vladimir Druzenko <vvd> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | vvd | ||||||
| Priority: | --- | Flags: | kevinz5000:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
I am the maintainer. This port need more love.
- Replace PORTVERSION with DISTVERSION.
- Fix warnings from portclippy.
- Remove unnecessary MKDIRs.
- Merge COPYTREE_SHARE.
@@ -1,9 +1,9 @@
PORTNAME= gspiceui
-PORTVERSION= 1.1.00
-PORTREVISION= 7
+DISTVERSION= 1.1.00
+PORTREVISION= 8
CATEGORIES= cad
-MASTER_SITES= SF/${PORTNAME}/gSpiceUI/${PORTNAME}-v${PORTVERSION}
-DISTNAME= ${PORTNAME}-v${PORTVERSION}
+MASTER_SITES= SF/${PORTNAME}/gSpiceUI/${PORTNAME}-v${DISTVERSION}
+DISTNAME= ${PORTNAME}-v${DISTVERSION}
MAINTAINER= kevinz5000@gmail.com
COMMENT= GUI for ngspice and gnucap circuit simulators
@@ -11,10 +11,8 @@ WWW= http://users.tpg.com.au/micksw012/gspiceui.html
LICENSE= GPLv3
-OPTIONS_DEFINE= DOCS EXAMPLES
-
-USE_WX= 3.0
USES= compiler:c++11-lib gmake pkgconfig
+USE_WX= 3.0
CXXFLAGS+= -std=c++11
@@ -22,10 +20,12 @@ DESKTOP_ENTRIES= "GSpiceUI" "Circuit Simulator GUI" \
"${PREFIX}/share/pixmaps/gspiceui-48x48.xpm" \
"gspiceui" "Science;Electronics;" false
-PORTDOCS= *
-PORTEXAMPLES= *
PLIST_FILES= bin/gspiceui share/pixmaps/gspiceui-48x48.xpm \
share/man/man1/gspiceui.1.gz
+PORTDOCS= *
+PORTEXAMPLES= *
+
+OPTIONS_DEFINE= DOCS EXAMPLES
.include <bsd.port.pre.mk>
@@ -34,7 +34,7 @@ CFLAGS:= ${CFLAGS:C/-O[2-9]/-O1/g}
.endif
post-patch:
- @${REINPLACE_CMD} -e 's|share/gspiceui|${DOCSDIR}|g' \
+ @${REINPLACE_CMD} -e 's|/share/gspiceui|${DOCSDIR:S|^${PREFIX}||}|g' \
${WRKSRC}/src/main/HelpTasks.cpp
do-install:
@@ -42,13 +42,9 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/src/icons/gspiceui-48x48.xpm \
${STAGEDIR}${PREFIX}/share/pixmaps
${INSTALL_MAN} ${WRKSRC}/gspiceui.1 ${STAGEDIR}${PREFIX}/share/man/man1
- @${MKDIR} ${STAGEDIR}${DOCSDIR}
@(cd ${WRKSRC} && ${COPYTREE_SHARE} html ${STAGEDIR}${DOCSDIR} \
"! -name Makefile")
- @${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
-.for dir in lib sch
- @(cd ${WRKSRC} && ${COPYTREE_SHARE} ${dir} ${STAGEDIR}${EXAMPLESDIR} \
+ @(cd ${WRKSRC} && ${COPYTREE_SHARE} "lib sch" ${STAGEDIR}${EXAMPLESDIR} \
"! -name Makefile")
-.endfor
.include <bsd.port.post.mk>
The host in WWW users.tpg.com.au is not resolved. There are newer releases: https://sourceforge.net/projects/gspiceui/files/gSpiceUI/ https://sourceforge.net/p/gspiceui/news/ Thanks for taking a look. - Let's replace WWW with the SourceForge front page: https://sourceforge.net/projects/gspiceui/ - Thanks for the other fixes. Approved. - I'll take a look at updating the version. If you'd like we can do that separately so that we get in this fix. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9a823ec6ed60849912a65d729ae4d706db0a290c commit 9a823ec6ed60849912a65d729ae4d706db0a290c Author: Kevin Zheng <kevinz5000@gmail.com> AuthorDate: 2026-05-16 02:48:35 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2026-05-16 02:48:35 +0000 cad/gspiceui: Fix documentation path Improve port: - Replace PORTVERSION with DISTVERSION. - Fix warnings from portclippy. - Remove unnecessary MKDIRs. - Merge COPYTREE_SHARE. PR: 295290 Reported by: Nilton Jose Rizzo Sponsored by: UNIS Labs Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org> MFH: 2026Q2 cad/gspiceui/Makefile | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) A commit in branch 2026Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bac1f149daaad0f97113d16295206163ace95c4a commit bac1f149daaad0f97113d16295206163ace95c4a Author: Kevin Zheng <kevinz5000@gmail.com> AuthorDate: 2026-05-16 02:48:35 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2026-05-16 02:51:44 +0000 cad/gspiceui: Fix documentation path Improve port: - Replace PORTVERSION with DISTVERSION. - Fix warnings from portclippy. - Remove unnecessary MKDIRs. - Merge COPYTREE_SHARE. PR: 295290 Reported by: Nilton Jose Rizzo Sponsored by: UNIS Labs Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org> MFH: 2026Q2 (cherry picked from commit 9a823ec6ed60849912a65d729ae4d706db0a290c) cad/gspiceui/Makefile | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) Created attachment 270774 [details]
v1: Update 1.1.00 => 1.2.87
Check this patch please.
Build and run without errors on 14.4 amd64.
Tested and working well for me, approved. Thanks for doing all the work for me :) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7995bb92507110ffd1fdad647bb8ec2d8151d0a1 commit 7995bb92507110ffd1fdad647bb8ec2d8151d0a1 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2026-05-17 06:42:19 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2026-05-17 06:42:19 +0000 cad/gspiceui: Update 1.1.0 => 1.2.87 Release Notes: https://sourceforge.net/projects/gspiceui/files/gSpiceUI/gspiceui-v1.2.36/release-notes-v1.2.36.txt https://sourceforge.net/projects/gspiceui/files/gSpiceUI/gspiceui-v1.2.87/release-notes-v1.2.87.txt PR: 295290 Approved by: Kevin Zheng <kevinz5000@gmail.com> (maintainer) Sponsored by: UNIS Labs cad/gspiceui/Makefile | 14 ++++----- cad/gspiceui/distinfo | 5 ++-- cad/gspiceui/files/patch-src_Makefile | 49 +++++++++++++++---------------- cad/gspiceui/files/patch-src_TypeDefs.hpp | 22 +++----------- 4 files changed, 37 insertions(+), 53 deletions(-) |
Created attachment 270733 [details] Patch gspiceui's binary does some automatic LOCALBASE detection using the full executable path, so the REINPLACE_CMD does not need LOCALBASE. Reported by: Nilton Jose Rizzo