Bug 297251

Thanks!

Testing now...

Created attachment 273464 [details]
net/turnserver: update to 4.16.0 and cleanup Makefile

@Frank Wall
Thanks for the heads-up, and for taking the time to
submit a patch! Your patch was good. But the Makefile
was in such bad shape, that I took this opportunity to
clean it up -- style(9), port(lint|fmt|clippy).

Thanks again!

@committer
The only functional change to the Makefile rewuired
to update this port is:
DISTVERSION=	4.16.0
the rest is to follow the style(9) guide.
I only mention this because conforming to style(9)
makes the diff messy and hard to follow. Other than
that, the only other change is to: distinfo.

All tests return OK

Thanks!

Comment 3 Yusuf Yaman 2026-08-04 20:32:34 UTC

Hi, 

Thank you for the collaboration!

While we're at it, can we also fix the bug #296810 (Run turnserver as non-root by default)?

Build seems fine in Poudriere on 14.4-RELEASE-amd64-main-4d5aad2430d2 including `make test`.

Created attachment 273473 [details]
update to 4.16.0, allow run as non-root and cleanup Makefile

OK this patch is as the last one. But adds the ability to
run as non-root (from bug #296810).

All builds/tests return OK.

Files affected:
Makefile
turnserver.in
GIDs
UIDs

Thanks!

Comment 5 commit-hook 2026-08-05 09:12:13 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=87d11fd7305cb245dff284e34be3a5c0c423aa60

commit 87d11fd7305cb245dff284e34be3a5c0c423aa60
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2026-08-04 19:04:49 +0000
Commit:     Yusuf Yaman <nxjoseph@FreeBSD.org>
CommitDate: 2026-08-05 09:10:05 +0000

    net/turnserver: Update 4.14.0 => 4.16.0

    Port changes:
    - Run turnserver as non-root by default.
    - Pet port(lint|fmt|clippy).

    PR:             297251, 296810
    Reported by:    Frank Wall <freebsd@moov.de>
    Reported by     Zixu Wu <zx@bv3.dev>
    Approved by:    Chris Hutchinson <portmaster@bsdforge.com> (maintainer)
    Approved by:    osa, vvd (Mentors, implicit)
    Co-authored-by: Frank Wall <freebsd@moov.de>
    Co-authored-by: Zixu Wu <zx@bv3.dev>
    Security:       GHSA-5538-7cxj-5jcc
    MFH:            2026Q3

 GIDs                                |   2 +-
 UIDs                                |   2 +-
 net/turnserver/Makefile             | 106 ++++++++++++++++++++----------------
 net/turnserver/distinfo             |   4 +-
 net/turnserver/files/pkg-message.in |   4 ++
 net/turnserver/files/turnserver.in  |   8 ++-
 6 files changed, 74 insertions(+), 52 deletions(-)

Comment 6 commit-hook 2026-08-05 09:12:17 UTC

A commit in branch 2026Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8bd693b6edc9d83ceecdafa886b4185b7f3f0623

commit 8bd693b6edc9d83ceecdafa886b4185b7f3f0623
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2026-08-04 19:04:49 +0000
Commit:     Yusuf Yaman <nxjoseph@FreeBSD.org>
CommitDate: 2026-08-05 09:11:54 +0000

    net/turnserver: Update 4.14.0 => 4.16.0

    Port changes:
    - Run turnserver as non-root by default.
    - Pet port(lint|fmt|clippy).

    PR:             297251, 296810
    Reported by:    Frank Wall <freebsd@moov.de>
    Reported by     Zixu Wu <zx@bv3.dev>
    Approved by:    Chris Hutchinson <portmaster@bsdforge.com> (maintainer)
    Approved by:    osa, vvd (Mentors, implicit)
    Co-authored-by: Frank Wall <freebsd@moov.de>
    Co-authored-by: Zixu Wu <zx@bv3.dev>
    Security:       GHSA-5538-7cxj-5jcc
    MFH:            2026Q3

    (cherry picked from commit 87d11fd7305cb245dff284e34be3a5c0c423aa60)

 GIDs                                |   2 +-
 UIDs                                |   2 +-
 net/turnserver/Makefile             | 106 ++++++++++++++++++++----------------
 net/turnserver/distinfo             |   4 +-
 net/turnserver/files/pkg-message.in |   4 ++
 net/turnserver/files/turnserver.in  |   8 ++-
 6 files changed, 74 insertions(+), 52 deletions(-)

Comment 7 Yusuf Yaman 2026-08-05 09:15:25 UTC

(In reply to Chris Hutchinson from comment #4)
Thanks!

As Frank said this below in the other PR, I have added it as a note into pkg-message.

> Please be aware that running as non-root user may require additional workarounds on
> FreeBSD, as suggested by this bug report:
> https://github.com/coturn/coturn/issues/1098

Committed.

A big thanks to everyone for your time on this!