Bug 29764
| Summary: | sysinstall puts confusing message in /etc/rc.conf about 'this file' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Hans Hoppe <h.hoppe> | ||||
| Component: | conf | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | 4.3-STABLE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Hans Hoppe
2001-08-16 08:10:01 UTC
this was, on the fateful occasion around Aug 16 03:08 -0400, sent by Hans Hoppe > > ... > >Description: > /stand/sysinstall puts the following text in /etc/rc.conf: > > # This file now contains just the overrides from /etc/defaults/rc.conf > # please make all changes to this file. > > There could be confusion whether 'this file' on the second line refers to > /etc/defaults/rc.conf or /etc/rc.conf. > ... > >Fix: > Suggested diff for config.c: > > --- usr/src/release/sysinstall/config.c.orig Wed Jul 4 08:56:37 2001 > +++ usr/src/release/sysinstall/config.c Thu Aug 16 08:49:25 2001 > @@ -389,7 +389,7 @@ > return; > if (write_header) { > fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n"); > - fprintf(rcSite, "# please make all changes to this file.\n\n"); > + fprintf(rcSite, "# please make all changes to /etc/rc.conf.\n\n"); > fprintf(rcSite, "# Enable network daemons for user convenience.\n"); > if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc))) > fprintf(rcSite, "# Created: %s", cp); i think it will be better if "this" and "/etc/rc.conf" are interchanged to print... # /etc/rc.conf file now contains just the overrides from # /etc/defaults/rc.conf please make all changes to this file. ...here is the patch... --- src/release/sysinstall/config.c.old Thu Aug 16 03:28:19 2001 +++ src/release/sysinstall/config.c Thu Aug 16 03:29:49 2001 @@ -388,8 +388,8 @@ if (!rcSite) return; if (write_header) { - fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n"); - fprintf(rcSite, "# please make all changes to this file.\n\n"); + fprintf(rcSite, "# /etc/rc.conf file now contains just the overrides from \n"); + fprintf(rcSite, "# /etc/defaults/rc.conf please make all changes to this file.\n\n"); fprintf(rcSite, "# Enable network daemons for user convenience.\n"); if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc))) fprintf(rcSite, "# Created: %s", cp); -- so, do you like word games or scrabble? - parv here it is again w/ my correct email address. this was, on the fateful occasion around Aug 16 03:08 -0400, sent by Hans Hoppe > > ... > >Description: > /stand/sysinstall puts the following text in /etc/rc.conf: > > # This file now contains just the overrides from /etc/defaults/rc.conf > # please make all changes to this file. > > There could be confusion whether 'this file' on the second line refers to > /etc/defaults/rc.conf or /etc/rc.conf. > ... > >Fix: > Suggested diff for config.c: > > --- usr/src/release/sysinstall/config.c.orig Wed Jul 4 08:56:37 2001 > +++ usr/src/release/sysinstall/config.c Thu Aug 16 08:49:25 2001 > @@ -389,7 +389,7 @@ > return; > if (write_header) { > fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n"); > - fprintf(rcSite, "# please make all changes to this file.\n\n"); > + fprintf(rcSite, "# please make all changes to /etc/rc.conf.\n\n"); > fprintf(rcSite, "# Enable network daemons for user convenience.\n"); > if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc))) > fprintf(rcSite, "# Created: %s", cp); i think it will be better if "this" and "/etc/rc.conf" are interchanged to print... # /etc/rc.conf file now contains just the overrides from # /etc/defaults/rc.conf please make all changes to this file. ...here is the patch... --- src/release/sysinstall/config.c.old Thu Aug 16 03:28:19 2001 +++ src/release/sysinstall/config.c Thu Aug 16 03:29:49 2001 @@ -388,8 +388,8 @@ if (!rcSite) return; if (write_header) { - fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n"); - fprintf(rcSite, "# please make all changes to this file.\n\n"); + fprintf(rcSite, "# /etc/rc.conf file now contains just the overrides from \n"); + fprintf(rcSite, "# /etc/defaults/rc.conf please make all changes to this file.\n\n"); fprintf(rcSite, "# Enable network daemons for user convenience.\n"); if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc))) fprintf(rcSite, "# Created: %s", cp); -- so, do you like word games or scrabble? - parv on 2001-08-16 09:39 parv <parv_@yahoo.com> wrote: > [...] > > i think it will be better if "this" and "/etc/rc.conf" are > interchanged to print... > > # /etc/rc.conf file now contains just the overrides from > # /etc/defaults/rc.conf please make all changes to this file. > That depends on whether we're meant to make all changes to /etc/defaults/rc.conf or to /etc/rc.conf. I think we're supposed to leave /etc/defaults/rc.conf untouched and make changes to /etc/rc.conf. Greets, Hans -- Kabelfoon BV Phone: +31 174 615430 PO Box 45 Fax: +31 174 623860 2670 AA Naaldwijk WWW: http://www.kabelfoon.nl/ Netherlands Email: info@kabelfoon.nl State Changed From-To: open->closed Duplicate of PR bin/29736. |
