| Summary: | stable 4.3 kernel compile fails for multi-processor | ||
|---|---|---|---|
| Product: | Base System | Reporter: | satz |
| Component: | i386 | Assignee: | Peter Wemm <peter> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
satz
2001-08-20 04:20:01 UTC
On Sun, Aug 19, 2001 at 08:10:50PM -0700, Greg Satz wrote:
>
> >Number: 29882
> >Category: i386
> >Synopsis: stable 4.3 kernel compile fails for multi-processor
> >Originator: Greg Satz
> >Release: 4.3 stable
> >Organization:
> >Environment:
> >Description:
> fnu# make
> linking kernel
> mp_machdep.o: In function `ap_init':
> mp_machdep.o(.text+0x219c): undefined reference to `enable_sse'
> *** Error code 1
I can reproduce this when the config file includes 'options SMP', yet does
not include 'cpu I686_CPU'. Can you try the attached patch, it works here?
The patch is against -stable, but applies cleanly to -current with an offset.
G'luck,
Peter
--
When you are not looking at it, this sentence is in Spanish.
Index: src/sys/i386/i386/mp_machdep.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/i386/mp_machdep.c,v
retrieving revision 1.115.2.9
diff -u -r1.115.2.9 mp_machdep.c
--- src/sys/i386/i386/mp_machdep.c 2001/08/15 01:23:50 1.115.2.9
+++ src/sys/i386/i386/mp_machdep.c 2001/08/20 10:11:06
@@ -2420,8 +2420,10 @@
/* set up FPU state on the AP */
npxinit(__INITIAL_NPXCW__);
+#if defined(I686_CPU)
/* set up SSE registers */
enable_sse();
+#endif
/* A quick check from sanity claus */
apic_id = (apic_id_to_logical[(lapic.id & 0x0f000000) >> 24]);
Responsible Changed From-To: freebsd-bugs->peter Peter Wemm was the one who introduced SSE. The patch in the audit trail seems to work here; it would be nice if it could make it into 4.4 before the release. That is the patch that I used and it works. I have a running kernel now. Thanks. Greg on 8/20/01 4:12 AM, Peter Pentchev at roam@ringlet.net wrote: > On Sun, Aug 19, 2001 at 08:10:50PM -0700, Greg Satz wrote: >> >>> Number: 29882 >>> Category: i386 >>> Synopsis: stable 4.3 kernel compile fails for multi-processor >>> Originator: Greg Satz >>> Release: 4.3 stable >>> Organization: >>> Environment: >>> Description: >> fnu# make >> linking kernel >> mp_machdep.o: In function `ap_init': >> mp_machdep.o(.text+0x219c): undefined reference to `enable_sse' >> *** Error code 1 > > I can reproduce this when the config file includes 'options SMP', yet does > not include 'cpu I686_CPU'. Can you try the attached patch, it works here? > The patch is against -stable, but applies cleanly to -current with an offset. > > G'luck, > Peter State Changed From-To: open->closed This has been fixed for quite some time. |