Bug 29946

Summary:	ntohl() and friends uses non-standard types
Product:	Base System	Reporter:	Jun-ichiro itojun Hagino <itojun>
Component:	i386	Assignee:	Bruce Evans <bde>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Unspecified
Hardware:	Any
OS:	Any

Description Jun-ichiro itojun Hagino 2001-08-22 06:10:17 UTC

	in XNET 5.2, ntohl() and htonl() are typed as follows:
		uint32_t ntohl(uint32_t x);
	and ntohs() and htons() are:
		uint16_t ntohs(uint16_t x);

	freebsd src/sys/i386/include/endian.h uses u_long and u_short, which
	are different from these types, and causes problem in portable
	appliation programming.

How-To-Repeat: 
	code inspection

Comment 1 Brian Somers freebsd_committer

2001-08-23 15:20:53 UTC

Responsible Changed
From-To: freebsd-bugs->bde

I tried to fix this some time ago (sys/i386/include/endian.h 1.19).  Bruce 
eventually mostly reverted the change (I didn't object), so I think this 
PR belongs to him :*D

Comment 2 Mike Barcroft freebsd_committer

2002-02-26 07:31:02 UTC

State Changed
From-To: open->closed


This was fixed some time ago in -CURRENT.  There are no plans to fix 
this this in -STABLE.