Bug 30054

Summary: ftp(1)'s fetch.c could easily have vhost support
Product: Base System Reporter: Joseph Mallett <jmallett>
Component: binAssignee: Mike Barcroft <mike>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Joseph Mallett 2001-08-24 21:00:00 UTC 
As Brett Glass pointed out in an earlier PR, if virtualhosting is being used (and ICANN or whoever said they won't allocate ips to people who should use name-based vhosts instead, so this is a 'big thing') it won't be made use of by ftp(1) as it doesn't send a Host: header. Of course, patching this is really trivial (I switched to asprintf() cause you never know how long a URL is, though I suppose you could go by the standards). And a patch is attached.

Fix: Aphex% cat host.patch
How-To-Repeat: ftp http://srcsys.org/work/penis-slapped-by-jkh.txt
and then
fetch http://srcsys.org/work/penis-slapped-by-jkh.txt
Comment 1 Mike Barcroft freebsd_committer freebsd_triage 2001-08-26 20:46:13 UTC 
Responsible Changed
From-To: freebsd-bugs->mike


I'll look into this.
Comment 2 Mike Barcroft freebsd_committer freebsd_triage 2001-08-30 02:00:53 UTC 
State Changed
From-To: open->analyzed


Committed a new patch from the originator to -CURRENT. 
MFC after 4.4-RELEASE.
Comment 3 colin.percival 2001-12-27 22:34:40 UTC 
   The commit notice for this 
(http://docs.freebsd.org/cgi/getmsg.cgi?fetch=946074+0+archive/2001/cvs-all/20010902.cvs-all) 
on August 29 was marked "MFC after: 8 days".
   Can this be done, and then can bin/30054 and bin/33237 be closed?

Colin Percival
Comment 4 Mike Barcroft freebsd_committer freebsd_triage 2002-02-26 06:04:30 UTC 
State Changed
From-To: analyzed->closed


lukemftp is schedule to be MFC'd shortly, which will solve this 
problem is -stable.