Bug 30229

Summary: sysinstall ignores the network device name given on command line
Product: Base System Reporter: Mikhail Teterin <mi>
Component: binAssignee: Murray Stokely <murray>
Status: Closed FIXED    
Severity: Affects Only Me CC: jkh
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Mikhail Teterin 2001-08-31 03:20:00 UTC 
	The sysinstall(8) allows to specify various parameters and
	invoke particular subparts of the program from command line.

	Unfortunately, when  the tcpMenuSelect part is  invoked, it will
	only  honor  the  specified  network  interface  (netDev),  when
	non-interactivity is also requested.

	This prevents its use for interactively configuring a _specified_
	interface -- the user first has to select it again from the menu.

Fix: The logic in  the tcpDeviceSelect() can, probably, be redone  -- it will
look somewhat redundant  after this patch. For that, it  is very simple.
It will cause the count of the  eligible devices to be 1, if the correct
device was already specified (through command or config file). If it was
not, the variable_get() call will return  NULL and the old behavior will
take place:
How-To-Repeat: 
	sysinstall netDev=dc0 tcpMenuSelect
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2001-08-31 05:06:43 UTC 
Responsible Changed
From-To: freebsd-bugs->jkh

Sysinstall is Jordan's... :)
Comment 2 jkh freebsd_committer freebsd_triage 2001-08-31 05:30:19 UTC 
Responsible Changed
From-To: jkh->eric

Because Eric touched it last
Comment 3 Murray Stokely freebsd_committer freebsd_triage 2001-09-05 09:10:09 UTC 
State Changed
From-To: open->analyzed

Your patch has been committed to -CURRENT, thanks!
Comment 4 Murray Stokely freebsd_committer freebsd_triage 2001-09-05 09:10:09 UTC 
Responsible Changed
From-To: eric->murray

My MFC reminder.
Comment 5 Murray Stokely freebsd_committer freebsd_triage 2001-09-17 00:49:14 UTC 
State Changed
From-To: analyzed->closed

This functionality has been added to -CURRENT and -STABLE.  Thanks!