Bug 30508

Summary:

STABLE sysinstall scripted installs broken since 2001/08/31

Product:

Base System

Reporter:

Alan Judge <Alan.Judge>

Component:

bin

Assignee:

jkh

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

Priority:

Normal

Version:

Unspecified

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Alan Judge 2001-09-11 12:00:00 UTC

	A recent patch to release/sysinstall/msg.c by jkh has broken scripted
	installs.  I think the comments in msg.c are wrong leading to the wrong
	code being committed for non-interactive installs.

	It seems msgYesNo follows the dialog DITEM_SUCCESS/FAILURE model and
	returns 0 for success and 1 for failure.

Fix: Patch below against STABLE.

	I'm building a new test release now, but given the approaching
	release thought it best to file rapidly so this can be
	fixed before 4.4 ships.  I'll followup to the PR once I've
	tested my new CD.

	I'd request an immediate commit to STABLE if this looks ok.
How-To-Repeat: 	Attempt a scripted install using a config file.
	installCommit fails quickly.

Comment 1 Peter Pentchev freebsd_committer

2001-09-11 12:06:35 UTC

Responsible Changed
From-To: freebsd-bugs->jkh

sysinstall is mainly his, and  this really does seem critical 
in view of the impending release.

Comment 2 Alan Judge 2001-09-11 18:34:40 UTC

Just to confirm: I've now tested, between being sickened by the events
on TV, and
this patch fixes my problem with scripted installs.

A.

Comment 3 jkh freebsd_committer

2001-09-11 21:44:03 UTC

State Changed
From-To: open->closed

Thanks, fixed!