Bug 30539

Summary: [PATCH] pull some magic numbers out of the ata code
Product: Base System Reporter: Tony Finch <dot>
Component: kernAssignee: Søren Schmidt <sos>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Tony Finch 2001-09-13 00:50:01 UTC 
There are some magic numbers in the ata code related to timeouts
and so forth that would be better coded as #defined constants.
Comment 1 alex.neyman 2001-09-13 07:17:29 UTC 
Regarding also misc/30536 PR, better yet as a sysctl's than #ifdefs?

Regards,
Alexey.
Comment 2 dd freebsd_committer freebsd_triage 2001-09-13 12:16:08 UTC 
Responsible Changed
From-To: freebsd-bugs->sos

Over to maintainer.
Comment 3 Søren Schmidt freebsd_committer freebsd_triage 2001-09-13 12:24:45 UTC 
State Changed
From-To: open->closed

I'll consider doing this as defines, but there is no need for that, 
and these values should NOT be changed under any circumstances, 
and thats why they should NOT be sysctl's at all.