Bug 30647
| Summary: | "make release" in src/release/ creates ports.tgz that includes distfiles | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | sa2c <sa2c> | ||||
| Component: | misc | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | 4.4-RELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
On Tue, Sep 18, 2001 at 08:00:37AM -0700, NIIMI Satoshi wrote:
>
> >Number: 30647
> >Category: misc
> >Synopsis: "make release" in src/release/ creates ports.tgz that includes distfiles
> >Originator: NIIMI Satoshi
> >Release: 4.4-RELEASE
> >Organization:
> >Environment:
> FreeBSD berkeley.sa2c.net 4.4-RELEASE FreeBSD 4.4-RELEASE #1: Sun Sep 16 13:03:19 JST 2001 sa2c@berkeley.sa2c.net:/usr/obj/usr/src/sys/BERKELEY i386
> >Description:
> "make release" in src/relase with very large /usr/ports/distfiles,
> cdrom.1 target in src/relase/Makefile failes to remove distfile.
> This causes very large (for me, over 5GB)
> ${CHROOT}/R/cdrom/disc1/ports/ports.tgz.
>
> >How-To-Repeat:
> cd /usr/ports; make -k BATCH=yes fetch
> cd /usr/src/release; make release RELEASETAG=RELENG_4_4_0_RELEASE blah blah...
>
> >Fix:
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/release/Makefile,v
> retrieving revision 1.536.2.56
> diff -u -r1.536.2.56 Makefile
> --- Makefile 2001/09/13 06:58:31 1.536.2.56
> +++ Makefile 2001/09/18 14:57:39
> @@ -756,6 +756,7 @@
> @cp ${CD_DISC1}/floppies/boot.flp ${CD_DISC2}/floppies
> .endif
> .if !defined(NOPORTS)
> + @find /usr/ports/distfiles -type f -print0 | xargs -0 rm -rf --
> @-rm -rf /usr/ports/distfiles/*
> @mkdir -p ${CD_DISC1}/ports && \
> tar --exclude CVS -czf ${CD_DISC1}/ports/ports.tgz -C /usr ports && \
Without actually having looked at the problem (the 'rm -rf' at the next
line is supposed to do the trick), the line you added could be also
written as:
@find /usr/ports/distfiles -type f -delete
It is another question just why the rm -rf cannot really delete things..
G'luck,
Peter
--
Hey, out there - is it *you* reading me, or is it someone else?
Peter Pentchev <roam@ringlet.net> writes: > Without actually having looked at the problem (the 'rm -rf' at the next > line is supposed to do the trick), the line you added could be also > written as: > > @find /usr/ports/distfiles -type f -delete Yes. > It is another question just why the rm -rf cannot really delete things.. I'm sorry to forget include the error message. The reason why 'rm -rf' failed is rm: argument list too long Thanks, I assume that this problem is already gone. Would you please check current src/release/Makefile? If it is OK for you, I wanna close this PR. -- - Makoto `MAR' Matsushita State Changed From-To: open->feedback Still awaiting the submitter's feedback. State Changed From-To: feedback->closed The submitter agrees to close this PR (see freebsd-bugs@FreeBSD.org). |
"make release" in src/relase with very large /usr/ports/distfiles, cdrom.1 target in src/relase/Makefile failes to remove distfile. This causes very large (for me, over 5GB) ${CHROOT}/R/cdrom/disc1/ports/ports.tgz. How-To-Repeat: cd /usr/ports; make -k BATCH=yes fetch cd /usr/src/release; make release RELEASETAG=RELENG_4_4_0_RELEASE blah blah...