Bug 30814

Hi,
I got this idea of adding more options to the Makefile and trying to minimize
the number of requests I decided to add this to my first request although its
not quite with the subject...I hope I'm doing the right thing.
The added options are explained in the text below.

*** Makefile.orig	Tue Sep 25 11:38:24 2001
--- Makefile	Wed Sep 26 22:41:40 2001
***************
*** 34,39 ****
--- 34,43 ----
  # WITH_MYSQL	- allow authentitation via mysql
  # WITH_APOP     - allow apop authentication
  # WITHOUT_ROAMING - disallow roaming users
+ # WITH_AUTH_LOGGING - Log when people authenticate with pop
+ # WITH_SQWEBMAIL_PASS - Enable support for sqwebmail passwords
+ # WITH_IP_ALIAS_DOMAINS - Enable virutal domain lookup via reverse ip address
+ #                         lookup for virtual domains
  #
  # Set these to the values you'd prefer
  #
***************
*** 48,53 ****
--- 52,58 ----
  # WITH_MYSQL_USER - the username for connecting to the MySQL server (root)
  # WITH_MYSQL_PASSWD - the password for connecting to the MySQL server (gipgap)
  # WITH_MYSQL_DB - the name of the MySQL database to use (vpopmail)
+ # WITH_MYSQL_SERVER - the name of the server with the MySQL database (localhost)
  # VCHKPW_GID	- the group ID of the new vchkpw group (89)
  # VPOPMAIL_UID	- the user ID of the new vpopmail user (89)
  #
***************
*** 109,114 ****
--- 114,131 ----
  CONFIGURE_ARGS+=	--enable-default-domain=${DEFAULT_DOMAIN}
  .endif
  
+ .if defined(WITH_AUTH_LOGGING)
+ CONFIGURE_ARGS+=	--enable-auth-logging=y
+ .endif
+ 
+ .if defined(WITH_SQWEBMAIL_PASS)
+ CONFIGURE_ARGS+=	--enable-sqwebmail-pass=y
+ .endif
+ 
+ .if defined(WITH_IP_ALIAS_DOMAINS)
+ CONFIGURE_ARGS+=	--enable-ip-alias-domains=y
+ .endif
+ 
  #
  # This port doesn't honour PREFIX, it honours vpopmail's home directory.
  # Since we create vpopmail if it doesn't exist, we set it so that it
***************
*** 126,131 ****
--- 143,151 ----
  .endif
  .if defined(WITH_MYSQL_DB)
  	${PERL} -pi -e "s/(#define MYSQL_DATABASE.*)vpopmail(.*)/\$$1${WITH_MYSQL_DB}\$$2/" ${WRKSRC}/vmysql.h
+ .endif
+ .if defined(WITH_MYSQL_SERVER)
+ 	${PERL} -pi -e "s/(#define MYSQL_SERVER.*)localhost(.*)/\$$1${WITH_MYSQL_SERVER}\$$2/" ${WRKSRC}/vmysql.h
  .endif
  .endif

Any chance of someone either accepting or rejecting this?

			Oli

On Tue, 25 Sep 2001, Olafur Osvaldsson wrote:

> 
> >Number:         30814
> >Category:       ports
> >Synopsis:       Added option to specify the mysql server for vpopmail
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-ports
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          change-request
> >Submitter-Id:   current-users
> >Arrival-Date:   Tue Sep 25 05:20:00 PDT 2001
> >Closed-Date:
> >Last-Modified:
> >Originator:     Olafur Osvaldsson
> >Release:        FreeBSD 4.4-STABLE i386
> >Organization:
> Internet a Islandi hf.
> >Environment:
> System: FreeBSD isis.isnic.is 4.4-STABLE FreeBSD 4.4-STABLE #2: Fri Sep 21 01:14:26 GMT 2001 root@isis.isnic.is:/usr/obj/usr/src/sys/VA1220 i386
> 
> 
> >Description:
> 	I run the mysql server on a seperate machine and my guess is that many
> 	other do, so making this an option would be nice.
> 
> >How-To-Repeat:
> 
> >Fix:
> 
> *** Makefile.orig	Tue Sep 25 11:38:24 2001
> --- Makefile	Tue Sep 25 11:31:14 2001
> ***************
> *** 48,53 ****
> --- 48,54 ----
>   # WITH_MYSQL_USER - the username for connecting to the MySQL server (root)
>   # WITH_MYSQL_PASSWD - the password for connecting to the MySQL server (gipgap)
>   # WITH_MYSQL_DB - the name of the MySQL database to use (vpopmail)
> + # WITH_MYSQL_SERVER - the name of the server with the MySQL database (localhost)
>   # VCHKPW_GID	- the group ID of the new vchkpw group (89)
>   # VPOPMAIL_UID	- the user ID of the new vpopmail user (89)
>   #
> ***************
> *** 126,131 ****
> --- 127,135 ----
>   .endif
>   .if defined(WITH_MYSQL_DB)
>   	${PERL} -pi -e "s/(#define MYSQL_DATABASE.*)vpopmail(.*)/\$$1${WITH_MYSQL_DB}\$$2/" ${WRKSRC}/vmysql.h
> + .endif
> + .if defined(WITH_MYSQL_SERVER)
> + 	${PERL} -pi -e "s/(#define MYSQL_SERVER.*)localhost(.*)/\$$1${WITH_MYSQL_SERVER}\$$2/" ${WRKSRC}/vmysql.h
>   .endif
>   .endif
>   
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message

-- 
Olafur Osvaldsson
Systems Administrator
Internet Iceland inc.
Tel:   +354 525-5291
Email: oli@isnic.is

Comment 3 Tetsurou Okazaki 2001-10-07 19:09:35 UTC

Responsible Changed
From-To: freebsd-ports->nbm

over to maintainer

Comment 4 Peter Pentchev 2001-11-04 12:09:45 UTC

Responsible Changed
From-To: nbm->roam

I took over maintainership from Neil.

Been over a month now and I'm still waiting for this to be submitted...

				Oli

On Tue, 25 Sep 2001, Olafur Osvaldsson wrote:

> 
> >Number:         30814
> >Category:       ports
> >Synopsis:       Added option to specify the mysql server for vpopmail
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-ports
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          change-request
> >Submitter-Id:   current-users
> >Arrival-Date:   Tue Sep 25 05:20:00 PDT 2001
> >Closed-Date:
> >Last-Modified:
> >Originator:     Olafur Osvaldsson
> >Release:        FreeBSD 4.4-STABLE i386
> >Organization:
> Internet a Islandi hf.
> >Environment:
> System: FreeBSD isis.isnic.is 4.4-STABLE FreeBSD 4.4-STABLE #2: Fri Sep 21 01:14:26 GMT 2001 root@isis.isnic.is:/usr/obj/usr/src/sys/VA1220 i386
> 
> 
> >Description:
> 	I run the mysql server on a seperate machine and my guess is that many
> 	other do, so making this an option would be nice.
> 
> >How-To-Repeat:
> 
> >Fix:
> 
> *** Makefile.orig	Tue Sep 25 11:38:24 2001
> --- Makefile	Tue Sep 25 11:31:14 2001
> ***************
> *** 48,53 ****
> --- 48,54 ----
>   # WITH_MYSQL_USER - the username for connecting to the MySQL server (root)
>   # WITH_MYSQL_PASSWD - the password for connecting to the MySQL server (gipgap)
>   # WITH_MYSQL_DB - the name of the MySQL database to use (vpopmail)
> + # WITH_MYSQL_SERVER - the name of the server with the MySQL database (localhost)
>   # VCHKPW_GID	- the group ID of the new vchkpw group (89)
>   # VPOPMAIL_UID	- the user ID of the new vpopmail user (89)
>   #
> ***************
> *** 126,131 ****
> --- 127,135 ----
>   .endif
>   .if defined(WITH_MYSQL_DB)
>   	${PERL} -pi -e "s/(#define MYSQL_DATABASE.*)vpopmail(.*)/\$$1${WITH_MYSQL_DB}\$$2/" ${WRKSRC}/vmysql.h
> + .endif
> + .if defined(WITH_MYSQL_SERVER)
> + 	${PERL} -pi -e "s/(#define MYSQL_SERVER.*)localhost(.*)/\$$1${WITH_MYSQL_SERVER}\$$2/" ${WRKSRC}/vmysql.h
>   .endif
>   .endif
>   
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message

-- 
Olafur Osvaldsson
Systems Administrator
Internet Iceland inc.
Tel:   +354 525-5291
Email: oli@isnic.is

On Thu, Dec 13, 2001 at 03:31:21AM +0000, Olafur Osvaldsson wrote:
> Hi,
> Is there any chance of you puting these changes into the vpopmail port, if you
> need a newer diff I can provide it, just show some interest...  ;)
> 
> If you don't like what I suggest please tell me and close the ticket.

Apologies for not replying to you sooner; as a matter of fact, your
changes have been somewhat overtaken by events :)

The sqwebmail support has been there in the mail/vpopmail Makefile
since rev. 1.9, committed by Neil on March 1, 2001.  It's just that
it has not been documented :)  The make(1) knob to enable it is
WITH_SQWEBMAIL.

The IP aliasing support - I committed a different version in rev. 1.15
on Nov 4 upon a request by Valentin Zahariev <curly@e-card.bg>.

The MySQL server support - I committed a more elaborate version in
rev 1.16 as part of the upgrade to vpopmail-5.0.

Once again, I apologize for ignoring your PR :(  Are you satisfied with
the changes that have gone in the vpopmail port?

G'luck,
Peter

-- 
This sentence contains exactly threee erors.

It seems to include now what I was looking for.

Thank you for taking the time to close this 3 month old PR.

On Thu, 20 Dec 2001, Peter Pentchev wrote:

> On Thu, Dec 13, 2001 at 03:31:21AM +0000, Olafur Osvaldsson wrote:
> > Hi,
> > Is there any chance of you puting these changes into the vpopmail port, if you
> > need a newer diff I can provide it, just show some interest...  ;)
> > 
> > If you don't like what I suggest please tell me and close the ticket.
> 
> Apologies for not replying to you sooner; as a matter of fact, your
> changes have been somewhat overtaken by events :)
> 
> The sqwebmail support has been there in the mail/vpopmail Makefile
> since rev. 1.9, committed by Neil on March 1, 2001.  It's just that
> it has not been documented :)  The make(1) knob to enable it is
> WITH_SQWEBMAIL.
> 
> The IP aliasing support - I committed a different version in rev. 1.15
> on Nov 4 upon a request by Valentin Zahariev <curly@e-card.bg>.
> 
> The MySQL server support - I committed a more elaborate version in
> rev 1.16 as part of the upgrade to vpopmail-5.0.
> 
> Once again, I apologize for ignoring your PR :(  Are you satisfied with
> the changes that have gone in the vpopmail port?
> 
> G'luck,
> Peter
> 
> -- 
> This sentence contains exactly threee erors.

-- 
Olafur Osvaldsson
Systems Administrator
Internet Iceland inc.
Tel:   +354 525-5291
Email: oli@isnic.is

Comment 8 Peter Pentchev 2001-12-26 00:50:44 UTC

State Changed
From-To: open->closed

Overtaken by events.