Bug 30838

Summary: wrap in <command> the only instance of ipfw that isn't marked up like this in dialup-firewall article
Product: Documentation Reporter: Giorgos Keramidas <charon>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-aa none

Description Giorgos Keramidas 2001-09-26 12:20:00 UTC
	The attached patch wraps in <command>...</command> the only instance of
	`ipfw' in the running text of the dialup-firewall that is not marked as
	<command> and is not a &man.ipfw.8; entity.
Comment 1 Murray Stokely freebsd_committer freebsd_triage 2001-09-26 22:46:14 UTC
On Wed, Sep 26, 2001 at 11:33:39AM +0300, Giorgos Keramidas wrote:
>  	  <para>This merely means that the maximum logging count for the
>  	    rule has been reached.  The rule itself is still working,
>  	    but it will no longer log until such time as you reset the
> -	    logging counters.  This can be done by simply prefixing the
> -	    ipfw command with the <literal>resetlog</literal> option.</para>
> +	    logging counters.  This can be done by simply prefixing
> +            <command>ipfw</command> with the <literal>resetlog</literal> option.</para>
>          </answer>


  This sentence doesn't make any sense to me.  The correct answer to
the question is to run the ipfw command with the 'resetlog'
argument, but that is a very confusing way to describe it.  Also, we
should probably mention the bumping up of the log limit in the kernel
configuration that is discussed earlier in this article.  I agree that
we should add the markup to the ipfw command, but it doesn't do much
good if the sentence doesn't make sense in the first place.  How about
this : 

"You can reset the logging counters with the <command>ipfw
resetlog</command> command.  Alternatively, you may increase the log
limit in your kernel configuration file by increasing the
<option>IPFIREWALL_VERBOSE_LIMIT</option> option."

Sound good?

      - Murray
Comment 2 Giorgos Keramidas 2001-09-26 22:58:01 UTC
Murray Stokely <murray@FreeBSD.org> wrote:
> 
>   This sentence doesn't make any sense to me.


Doesn't make sense to me either, and I wanted to double check before suggesting
a replacement (my kernel does not have ipfw support).  Especially that
'prefixing' thing sounds awfuly confusing.  Feel free to change it, the
following looks a lot better:

> How about this : 
> 
> "You can reset the logging counters with the <command>ipfw
> resetlog</command> command.  Alternatively, you may increase the log
> limit in your kernel configuration file by increasing the
> <option>IPFIREWALL_VERBOSE_LIMIT</option> option."


-giorgos
Comment 3 Murray Stokely freebsd_committer freebsd_triage 2001-09-27 01:51:57 UTC
State Changed
From-To: open->closed

fixed, thanks!