Bug 31494

Summary: mod_perl fixes for apache13 port
Product: Ports & Packages Reporter: Dominic Mitchell <dom>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Dominic Mitchell 2001-10-25 18:50:00 UTC 
At present, the apache13 port has 2 incompatibilities with the mod_perl
port:

1.	mod_perl under -CURRENT complains that Perl was built with
	largefile support, but apache wasn't.  Part of this patch
	provides LARGEFILES option for compiling apache.

2.	It includes expat-lite, which prevents XML::Parser from being
	used inside mod_perl.  This is a real pain in the bum.  :-)
	Apache 1.3.22 specifically included support for using a system
	copy of expat in place of its own builtin version, in order to
	reduce incompatibilities.  This patch allows apache to look in
	/usr/local/include and /usr/local/lib to find expat.

	Possibly, it should be another option, WITH_EXPAT, which also
	uses a LIB_DEPEND?  I'm not sure.

Fix: Here's my patch.  It may be a little simplistic, however...
How-To-Repeat: 
1.	Install mod_perl on a -CURRENT machine and see the warning.

2.	Inside mod_perl, write a script that uses XML::Parser and watch
	the core dumps fly!
Comment 1 Андрей Чернов 2001-10-25 18:59:58 UTC 
On Thu, Oct 25, 2001 at 00:05:15 +0100, Dominic Mitchell wrote:
> 
> 	Possibly, it should be another option, WITH_EXPAT, which also
> 	uses a LIB_DEPEND?  I'm not sure.

If you want to use full expat, it should be directly specified with 
LIB_DEPEND, not as indirect guessing.

BTW, what are drawbacks to permanently include LARGEFILES and full expat 
support in apache? Is they are performance or size ones?

-- 
Andrey A. Chernov
http://ache.pp.ru/
Comment 2 Pete Fritchman freebsd_committer freebsd_triage 2001-10-27 08:46:39 UTC 
Responsible Changed
From-To: freebsd-ports->ache

Over to maintainer
Comment 3 Dominic Mitchell 2001-11-05 09:31:53 UTC 
On Thu, Oct 25, 2001 at 09:59:58PM +0400, Andrey A. Chernov wrote:
> On Thu, Oct 25, 2001 at 00:05:15 +0100, Dominic Mitchell wrote:
> > 
> > 	Possibly, it should be another option, WITH_EXPAT, which also
> > 	uses a LIB_DEPEND?  I'm not sure.
> 
> If you want to use full expat, it should be directly specified with 
> LIB_DEPEND, not as indirect guessing.

Right.  I'll adjust that.  However, is there any reason to not make
apache dependent on expat, generally?  It will reduce a number of
support problems with modules thgat use expat.

> BTW, what are drawbacks to permanently include LARGEFILES and full expat 
> support in apache? Is they are performance or size ones?

I'm not sure; the settings I used were suggested by mod_perl.  I would
imagine that testing on 4.4-STABLE would help, if it works there it
should be ok.

-Dom
Comment 4 Андрей Чернов 2001-11-05 11:32:41 UTC 
On Mon, Nov 05, 2001 at 09:31:53 +0000, Dominic Mitchell wrote:
> 
> Right.  I'll adjust that.  However, is there any reason to not make
> apache dependent on expat, generally?  It will reduce a number of
> support problems with modules thgat use expat.

As I already say, it depends of full expat library size and performance 
compared to expat lite. If tests shows that Apache will run with 
almost equal speed and size with full expat, we can switch to it.

> > BTW, what are drawbacks to permanently include LARGEFILES and full expat 
> > support in apache? Is they are performance or size ones?
> 
> I'm not sure; the settings I used were suggested by mod_perl.  I would
> imagine that testing on 4.4-STABLE would help, if it works there it
> should be ok.

If you show your test results indicating no drawbacks, both LARGEFILES and 
expat can be included into the main Apache port.

-- 
Andrey A. Chernov
http://ache.pp.ru/
Comment 5 Andrey A. Chernov freebsd_committer freebsd_triage 2003-06-07 02:58:30 UTC 
State Changed
From-To: open->closed

Full expat now is default now for apache port