Bug 31672
| Summary: | Build-stopping bug in sys/dev/ata/ata-all.c -STABLE | ||
|---|---|---|---|
| Product: | Base System | Reporter: | agifford |
| Component: | kern | Assignee: | freebsd-bugs (Nobody) <bugs> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
Go ahead and close this PR. It has been fixed. From CVS WEB (see http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/ata/ata-all.c) I read: ----------------------- Revision 1.50.2.23 / (download) - annotate - [select for diffs], Wed Oct 31 18:58:09 2001 UTC (3 hours, 10 minutes ago) by asmodai Branch: RELENG_4 Changes since 1.50.2.22: +1 -1 lines Fix result of pasting wrong buffer, this changes a MFC'd ID to the correct one. Notified of by: Michal Mertl <mime@traveller.cz> --------------------- Thank you for catching the typo, Michal Mertl and for fixing it quickly, asmodai! Aaron Gifford State Changed From-To: open->closed Fixed by asmodai. |
In the file /usr/src/sys/dev/ata/ata-all.c at line 259 and line 266, there are duplicate switch/case entries that cause buildkernel to fail. Here's a snippet from the file (line 258 to 267 - note the identical entries on 259 and 266): case 0x71998086: case 0x84ca8086: return "Intel PIIX4 ATA33 controller"; case 0x24218086: return "Intel ICH0 ATA33 controller"; case 0x24118086: case 0x84ca8086: return "Intel ICH ATA66 controller"; Fix: Remove one of the offending duplicates. I don't know which one is the correct one and which one is a typo, so I'll leave that to those wise in the realm of ATA drivers. How-To-Repeat: Try building a -STABLE kernel with ATA support today (31 Oct. 2001).