Bug 32235

Summary: /usr/ports/net/ntop is not $LOCALBASE clean
Product: Ports & Packages Reporter: Thomas Hurst <freaky>
Component: Individual Port(s)Assignee: bill fumerola <billf>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Thomas Hurst 2001-11-23 22:40:00 UTC
	The package's configure script wants to install to /usr/local,
	despite what $LOCALBASE is set to.

Fix: Pass configure --prefix=${PREFIX}, or maybe set
	CONFIGURE_ENV+=PREFIX="${PREFIX}", or whatever.
	IANAPM :)

	The following patch made it install fine on my machine:



HAS_CONFIGURE= yes
+CONFIGURE_ARGS+= --prefix=${PREFIX}
 ALL_TARGET=
 INSTALL_TARGET=        install install-man--qcG0XSFMbqI4BuxGVRHRx8FAiv1ROqUIAXPPfTkyY4ImsNeR
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig     Mon Sep 25 13:21:30 2000
+++ Makefile    Fri Nov 23 22:26:57 2001
@@ -16,6 +16,7 @@
 MAINTAINER=    billf@FreeBSD.org
How-To-Repeat: 	Change LOCALBASE in make.conf, cd /usr/ports/net/ntop && make,
	watch configure output.
Comment 1 dwcjr freebsd_committer freebsd_triage 2001-11-24 00:48:36 UTC
Responsible Changed
From-To: freebsd-ports->billf

Over to maintainer.
Comment 2 dwcjr 2001-11-24 01:03:43 UTC
each application doesn't install to localbase it installs into prefix. 
 It looks for dependencies in localbase
Comment 3 Thomas Hurst 2001-11-24 01:21:11 UTC
* David W. Chapman Jr. (dwcjr@inethouston.net) wrote:

> each application doesn't install to localbase it installs into prefix. 
>  It looks for dependencies in localbase

Shouldn't these both be the same?

-- 
Thomas 'Freaky' Hurst  -  freaky@aagh.net  -  http://www.aagh.net/
Comment 4 dwcjr 2001-11-24 01:23:52 UTC
On Sat, Nov 24, 2001 at 01:21:11AM +0000, Thomas Hurst wrote:
> * David W. Chapman Jr. (dwcjr@inethouston.net) wrote:
> 
> > each application doesn't install to localbase it installs into prefix. 
> >  It looks for dependencies in localbase
> 
> Shouldn't these both be the same?
> 
Only if the port doesn't have any dependencies but you still 
shouldn't assume they are in that case.  Your patch may be correct, 
but assuming things about localbase when they should be prefix are 
incorrect.
-- 
David W. Chapman Jr.
dwcjr@inethouston.net	Raintree Network Services, Inc. <www.inethouston.net>
dwcjr@freebsd.org	FreeBSD Committer <www.FreeBSD.org>
Comment 5 Thomas Hurst 2001-11-24 01:37:55 UTC
* David W. Chapman Jr. (dwcjr@inethouston.net) wrote:

> On Sat, Nov 24, 2001 at 01:21:11AM +0000, Thomas Hurst wrote:
> > * David W. Chapman Jr. (dwcjr@inethouston.net) wrote:
> >
> > > each application doesn't install to localbase it installs into
> > > prefix.  It looks for dependencies in localbase
> >
> > Shouldn't these both be the same?
>
> Only if the port doesn't have any dependencies

Why would they change in this case?  If I set localbase to /usr/pkg,
shouldn't it both look for deps in there and install in there?

This is why IANAPM (I Am Not A Ports Maintainer.. :)

<makes note to read some docs>

> but you still shouldn't assume they are in that case.  Your patch may
> be correct, but assuming things about localbase when they should be
> prefix are incorrect.

Ever get the feeling you shouldn't have changed something in the first
place?  No?  Damn :)

-- 
Thomas 'Freaky' Hurst  -  freaky@aagh.net  -  http://www.aagh.net/
Comment 6 bill fumerola freebsd_committer freebsd_triage 2002-01-04 01:17:57 UTC
State Changed
From-To: open->closed

committed.. sort of. CONFIGURE_ARGS+= --prefix=${PREFIX} is 
the long way of saying 'GNU_CONFIGURE= yes'. 

thanks for your submission.