Bug 32564

Summary: [PATCH] MAKEDEV.8 (i386) - wd# is replaced by ad#
Product: Documentation Reporter: Hiten Pandya <hiten>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Hiten Pandya 2001-12-06 20:40:01 UTC
The flaw in the MAKEDEV.8 (i386) man page says the wd# disk names still
exist.. while they have been completely changed to ad#.

The patch below resolves the issue by changing the wd# into ad# and the
patch also provide's a note to pre FreeBSD 4.3 Users that ad# needs to
be changed to wd#.

How-To-Repeat: Visit the MAKEDEV.8 (i386) Man Page
Comment 1 Dima Dorfman 2002-01-07 05:52:46 UTC
Hiten Pandya <hiten@uk.freebsd.org> wrote:
> *** MAKEDEV.8.old Thu Dec 6 19:48:53 2001
> --- MAKEDEV.8 Thu Dec 6 20:00:11 2001

This patch is corrupt.  I don't know how that came about.  Also, for
small and clean changes like this, unified diffs are much easier to
read [1].

> ***************
> *** 87,97 ****
> SCSI tape drives
> .It vty#
> set of 12 virtual console devices for syscons/pcvt/codrv
> ! .It wd#
> .Dq winchester
> disk drives (ST506, IDE, ESDI, RLL etc.)
> .It wt#
> QIC-interfaced (e.g. not SCSI) 3M cartridge tape
> .El
> .Sh FILES
> .Bl -tag -width /dev/xxxx -compact
> --- 87,103 ----
> SCSI tape drives
> .It vty#
> set of 12 virtual console devices for syscons/pcvt/codrv
> ! .It ad#
> .Dq winchester
> disk drives (ST506, IDE, ESDI, RLL etc.)
> .It wt#
> QIC-interfaced (e.g. not SCSI) 3M cartridge tape

This change is good in theory but is largely incomplete; ad# is not
"winchester disk drives".  There's a similar, but more complete,
change in the Alpha MAKEDEV.8 which I have merged to the i386 version.

> + .Sh NOTE
> + Please change
> + .Dq ad#
> + to
> + .Dq wd#
> + on systems older than FreeBSD 4.3.

I don't particularly like this.  For one, FreeBSD 4.3 used ad# by
default; wd# is only used on 3.x.  Further, mentioning upgrade quirks
in a manual page seems somewhat unnatural to me.  This should probably
be mentioned in UPDATING and/or the release notes if it isn't already.

I'd like to close this PR unless somebody feels strongly that this
last change should be made.

Thanks.

[1] I realize that this is my opinion, but I'm not alone in this
preference.
Comment 2 dd freebsd_committer freebsd_triage 2002-01-07 05:52:54 UTC
State Changed
From-To: open->feedback

This can probably be closed unless the originator feels strongly that 
his last change should be applied.
Comment 3 hitmaster 2002-01-21 17:01:36 UTC
> This can probably be closed unless the originator feels 
> strongly that his last change should be applied. 

hmm, this PR can be closed, as it is true that this Patch is mostly
incorrect, after dd pointed out the mistakes I made in this patch.

If there is a need for another patch, I will surely submit one, but I
am sure that the same type of change in the Alpha MAKEDEV.8 man page
can be applied into the i386 MAKEDEV.8 man page.

Otherwise, this PR can be closed without any problems. :-)

regards,
Hiten Pandya
<hiten@uk.FreeBSD.org>
<hitmaster@mysun.com>
Comment 4 Giorgos Keramidas freebsd_committer freebsd_triage 2002-01-21 18:13:08 UTC
State Changed
From-To: feedback->closed

By originator's request, 
after he discussed things with dd@FreeBSD.org.