Bug 32912

On Sun, Dec 16, 2001 at 09:36:34PM -0000, Carl Schmidt wrote:
> >Number:         32912
> >Category:       kern
> >Synopsis:       options misssing TCBHASHSIZE
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-bugs
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Sun Dec 16 13:40:01 PST 2001
> >Closed-Date:
> >Last-Modified:
> >Originator:     Carl Schmidt
> >Release:        FreeBSD 4.4-STABLE i386
> >Organization:
> >Environment:
> System: FreeBSD Carbon.SlackerBSD.ORG 4.4-STABLE FreeBSD 4.4-STABLE #0: Thu Dec 13 19:42:50 EST 2001 root@Carbon.SlackerBSD.ORG:/usr/obj/usr/src/sys/CARBON i386
> 
> >Description:
> /sys/conf/options is lacking TCBHASHSIZE and so is LINT.
> This isn't really a sw-bug but i don't think misc or doc-bug would really be
> appropriate either. Sorry (and correct me) if I'm wrong.
> 
> >How-To-Repeat:
> grep TCBHASHSIZE /sys/netinet/tcp_subr.c
> grep TCBHASHSIZE /sys/conf/options
> grep TCBHASHSIZE /sys/i386/conf/LINT
> 
> >Fix:
> --- options.old	Fri Nov  2 20:41:07 2001
> +++ options	Sun Dec 16 16:03:20 2001
> @@ -269,6 +269,7 @@
>  PPP_FILTER		opt_ppp.h
>  RANDOM_IP_ID
>  SLIP_IFF_OPTS		opt_slip.h
> +TCBHASHSIZE
>  TCPDEBUG
>  TCP_DROP_SYNFIN		opt_tcp_input.h
>  XBONEHACK
> 
> --- LINT.old	Fri Dec 14 22:29:03 2001
> +++ LINT	Sun Dec 16 16:35:39 2001
> @@ -556,6 +556,10 @@
>  # packets without touching the ttl).  This can be useful to hide firewalls
>  # from traceroute and similar tools.
>  #
> +# TCBHASHSIZE is the target size of the TCP PCB (process control block) hash
> +# tables.  This must be a power of 2.  The default is 512 (2^9). See tcp(4)
> +# for more information.
> +#
>  # TCPDEBUG is undocumented.
>  #
>  options 	MROUTING		# Multicast routing
> @@ -573,6 +577,7 @@
>  options 	IPFILTER_LOG		#ipfilter logging
>  options		IPFILTER_DEFAULT_BLOCK	#block all packets by default
>  options 	IPSTEALTH		#support for stealth forwarding
> +options		TCBHASHSIZE=512		#tcp pcb hash table size
>  options 	TCPDEBUG
>  
>  # RANDOM_IP_ID causes the ID field in IP packets to be randomized
> >Release-Note:
> >Audit-Trail:
> >Unformatted:

Sorry about the formatting mistake and the spelling error in the synopsis.

--- LINT.old	Fri Dec 14 22:29:03 2001
+++ LINT	Sun Dec 16 16:35:39 2001
@@ -556,6 +556,10 @@
 # packets without touching the ttl).  This can be useful to hide firewalls
 # from traceroute and similar tools.
 #
+# TCBHASHSIZE is the target size of the TCP PCB (process control block) hash
+# tables.  This must be a power of 2.  The default is 512 (2^9). See tcp(4)
+# for more information.
+#
 # TCPDEBUG is undocumented.
 #
 options 	MROUTING		# Multicast routing
@@ -573,6 +577,7 @@
 options 	IPFILTER_LOG		#ipfilter logging
 options	IPFILTER_DEFAULT_BLOCK	#block all packets by default
 options 	IPSTEALTH		#support for stealth forwarding
+options	TCBHASHSIZE=512		#tcp pcb hash table size
 options 	TCPDEBUG
 
 # RANDOM_IP_ID causes the ID field in IP packets to be randomized

-- 
Carl Schmidt

Comment 2 Sheldon Hearn 2001-12-30 13:34:47 UTC

Responsible Changed
From-To: freebsd-bugs->msmith

Mike made TCBHASHSIZE a compile-time tunable. 

Mike, if you don't have time for this, let me know and I'll do it 
myself.

Comment 3 Mark Peek 2002-07-08 03:54:13 UTC

State Changed
From-To: open->patched

Patched -current and waiting to MFC. 

Comment 4 Mark Peek 2002-07-08 03:54:13 UTC

Responsible Changed
From-To: msmith->mp

I'll take care of this one.

Comment 5 Bruce M Simpson 2004-06-23 10:11:24 UTC

State Changed
From-To: patched->closed

Kernel loader tunable net.inet.tcp.tcbhashsize now exists 

Comment 6 Bruce M Simpson 2004-06-23 10:11:24 UTC

Responsible Changed
From-To: mp->bms

I'll take this