Bug 32993

Summary: new em(4) driver breaks kernel build when only src-sys is present
Product: Base System Reporter: Jose M. Alcaide <jose>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.4-STABLE   
Hardware: Any   
OS: Any   

Description Jose M. Alcaide 2001-12-19 00:10:01 UTC
The recently committed em(4) driver breaks kernel compilation when only the
src-sys collection (AKA "kernel developer" distribution) is installed, since
sys/dev/if_em.h includes stddef.h.

Fix: 

I don't know.
How-To-Repeat: 
On any system with only src-base and src-sys collections installed:

# cd /usr/src
# make buildkernel
...
===> em
@ -> /usr/src/sys
machine -> /usr/src/sys/i386/include
perl @/kern/makeops.pl -h @/kern/device_if.m
perl @/kern/makeops.pl -h @/kern/bus_if.m
perl @/kern/makeops.pl -h @/pci/pci_if.m
touch opt_bdg.h
rm -f .depend
mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I- -I. -I@ -I@/../include -I/usr/obj/usr/src/i386/usr/include  /usr/src/sys/modules/em/../../dev/em/if_em.c /usr/src/sys/modules/em/../../dev/em/if_em_fxhw.c /usr/src/sys/modules/em/../../dev/em/if_em_phy.c
In file included from /usr/src/sys/modules/em/../../dev/em/if_em.c:39:
@/dev/em/if_em.h:74: stddef.h: No such file or directory
In file included from @/dev/em/if_em_osdep.h:92,
                 from @/dev/em/if_em_fxhw.h:105,
                 from /usr/src/sys/modules/em/../../dev/em/if_em_fxhw.c:42:
@/dev/em/if_em.h:74: stddef.h: No such file or directory
In file included from @/dev/em/if_em_osdep.h:92,
                 from @/dev/em/if_em_fxhw.h:105,
                 from /usr/src/sys/modules/em/../../dev/em/if_em_phy.c:42:
@/dev/em/if_em.h:74: stddef.h: No such file or directory
mkdep: compile failed
*** Error code 1

Stop in /usr/src/sys/modules/em.
Comment 1 brooks 2001-12-19 00:36:03 UTC
On Wed, Dec 19, 2001 at 01:07:38AM +0100, Jose M. Alcaide wrote:
> 
> >Description:
> 
> The recently committed em(4) driver breaks kernel compilation when only the
> src-sys collection (AKA "kernel developer" distribution) is installed, since
> sys/dev/if_em.h includes stddef.h.
> 
> >Fix:
> 
> I don't know.

At least in current just removing the line from if_em.h allows the
module to compile without warnings which would indicate it's unused so
just removing it would fix your problem.

-- Brooks
Comment 2 pdeuskar freebsd_committer freebsd_triage 2001-12-20 19:41:29 UTC
State Changed
From-To: open->closed

Removed unused stddef.h file from if_em.h. 
This was causing problems with compilation when only 
src-sys was present on the system.