Bug 33071

Summary: (no subject)
Product: Base System Reporter: Adrian Steinmann <ast>
Component: i386Assignee: GNATS administrator <gnats-admin>
Status: Closed FIXED    
Severity: Affects Only Me CC: msmith
Priority: Normal    
Version: 1.0-RELEASE   
Hardware: Any   
OS: Any   

Description Adrian Steinmann 2001-12-21 22:40:00 UTC
 Submitter-Id:	current-users
 Originator:	Adrian Steinmann <ast@marabu.ch>
 Organization:	Webgroup Consulting
 Confidential:	no
 Synopsis:	GENERIC bloat causes 'make world' to break (overfull floppy)
 Severity:	critical
 Priority:	medium
 Category:	i386
 Class:		sw-bug
 Release:	FreeBSD 4.4-STYX i386
 Environment:
 System: FreeBSD rumori.com 4.4-STYX FreeBSD 4.4-STYX #2: Fri Aug 31 13:23:17 MEST 2001 root@rumori.com:/usr/src/sys/compile/RUM i386
 
 Description:
 	Mid-December, 2001 on stable@freebsd.org, we see this thread:
 
 	Re: Waaaarg, we just blew out the kernel again..
 
 	Not the first time, probably not the last time either ;-)
 
 How-To-Repeat:
 	make release of -stable branch, it will fail because the GENERIC floppy
 	overflows (Mid-December 2001).
 
 Fix:
 	As I mentioned in stable@freebsd.org on Tue, 18 Dec 2001
 	in Message-Id: <200112181133.MAA11130@marabu.marabu.ch>
 
 	... a brighter future is indeed to modularize more drivers ...
 
 	As a stopgap, we can try to compress GENERIC better:
 
 	Here we have a patch to replace the gzip compression with 'bzip -1'
 	in src/release/Makefile. It has been tested: sysinstall went fine
 	on a custom-burnt CD made from the .../R/cdrom/disc1/ tree.
 
 	I have also checked that the loader can indeed load kernel.bz2 images.
 
 	Since this change is quite intrusive, I would expect a second independent
 	test to be done before commiting. Also, there might be a better place to
 	add the LOADER_BZIP2_SUPPORT=YES LOADER_NO_GZIP_SUPPORT=YES flags than
 	straight into WORLD_FLAGS. One might even consider changing the default
 	in the loader's Makefile. I will let the commiter decide.
 
 *** release/Makefile	2001/12/02 10:31:28	1.536.2.62
 --- release/Makefile	2001/12/21 22:05:38
 ***************
 *** 51,56 ****
 --- 51,59 ----
   #WORLD_FLAGS=-j4
   #KERNEL_FLAGS=-j4
   
 + # standardize on bzip instead of gzip to fit more GENERIC onto floppy
 + WORLD_FLAGS+= LOADER_BZIP2_SUPPORT=YES LOADER_NO_GZIP_SUPPORT=YES
 + 
   # If you are using a local CVS repository with components stored in 
   # non-standard modules, override these on the make commandline or
   # in the environment.
 ***************
 *** 636,655 ****
   	@gzip -9 ${RD}/mfsfd/stand/help/*.hlp
   	sh -e ${.CURDIR}/scripts/doFS.sh -s mfsroot ${RD} ${MNT} \
   		${MFSSIZE} ${RD}/mfsfd ${MFSINODE} ${MFSLABEL}
 ! 	@gzip -9vc mfsroot > mfsroot.gz
   .if ${MACHINE} == "pc98"
   	@sh -e ${.CURDIR}/scripts/doFS.sh ${RD}/floppies/mfsroot.flp \
 ! 		${RD} ${MNT} ${SMALLBOOTSIZE} mfsroot.gz \
   		${BOOTINODE} ${SMALLBOOTLABEL}
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=kern-small FDSIZE=SMALL
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=kern
   .else
   	@sh -e ${.CURDIR}/scripts/doFS.sh ${RD}/floppies/mfsroot.flp \
 ! 		${RD} ${MNT} ${BOOTSIZE} mfsroot.gz ${BOOTINODE} ${BOOTLABEL}
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=kern
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=boot FDSIZE=BIG
   .endif
 ! 	@rm mfsroot mfsroot.gz mfsroot.size
   	@echo "Regular and MFS boot floppies made."
   	touch release.8
   
 --- 639,658 ----
   	@gzip -9 ${RD}/mfsfd/stand/help/*.hlp
   	sh -e ${.CURDIR}/scripts/doFS.sh -s mfsroot ${RD} ${MNT} \
   		${MFSSIZE} ${RD}/mfsfd ${MFSINODE} ${MFSLABEL}
 ! 	@bzip2 -1vc mfsroot > mfsroot.bz2
   .if ${MACHINE} == "pc98"
   	@sh -e ${.CURDIR}/scripts/doFS.sh ${RD}/floppies/mfsroot.flp \
 ! 		${RD} ${MNT} ${SMALLBOOTSIZE} mfsroot.bz2 \
   		${BOOTINODE} ${SMALLBOOTLABEL}
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=kern-small FDSIZE=SMALL
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=kern
   .else
   	@sh -e ${.CURDIR}/scripts/doFS.sh ${RD}/floppies/mfsroot.flp \
 ! 		${RD} ${MNT} ${BOOTSIZE} mfsroot.bz2 ${BOOTINODE} ${BOOTLABEL}
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=kern
   	@cd ${.CURDIR} && ${MAKE} doMFSKERN FSIMAGE=boot FDSIZE=BIG
   .endif
 ! 	@rm mfsroot mfsroot.bz2 mfsroot.size
   	@echo "Regular and MFS boot floppies made."
   	touch release.8
   
 ***************
 *** 955,961 ****
   	@./write_mfs_in_kernel ${RD}/image.${FSIMAGE}/kernel mfsroot
   	@cp ${RD}/image.${FSIMAGE}/kernel ${RD}/kernels/MFSKERNEL.${FSIMAGE}
   .endif
 ! 	@gzip -9v ${RD}/image.${FSIMAGE}/kernel
   	@rm -f ${RD}/floppies/${FSIMAGE}.flp
   .if defined(FDSIZE) && ${FDSIZE} == "BIG"
   	sh -e ${.CURDIR}/scripts/doFS.sh ${RD}/floppies/${FSIMAGE}.flp \
 --- 958,964 ----
   	@./write_mfs_in_kernel ${RD}/image.${FSIMAGE}/kernel mfsroot
   	@cp ${RD}/image.${FSIMAGE}/kernel ${RD}/kernels/MFSKERNEL.${FSIMAGE}
   .endif
 ! 	@bzip2 -1v ${RD}/image.${FSIMAGE}/kernel
   	@rm -f ${RD}/floppies/${FSIMAGE}.flp
   .if defined(FDSIZE) && ${FDSIZE} == "BIG"
   	sh -e ${.CURDIR}/scripts/doFS.sh ${RD}/floppies/${FSIMAGE}.flp \
Comment 1 dd freebsd_committer freebsd_triage 2001-12-24 19:14:00 UTC
State Changed
From-To: open->closed

duplicate 33089