Bug 33202

On Wed, 26 Dec 2001, Chris Dillon wrote:

> >Fix:
> Since I won't be able to test any changes I make (I don't know how
> to cause an enclosure event out of the blue, and the box in
> question is also not in front of me right now) and since I'm
> really not all that good with C anyway, I'll leave this up to
> someone more qualified.

OK, I underestimated myself.  After some discussion with people in
#FreeBSD on IRC and trying several different routes, I finally decided
that just taking the printf arguments out of the lookup table was the
cleanest way to handle this.  Unfortunately the error messages won't
be quite as perfectly clear as they were before, but should still make
sense.  I'm currently running this patch on my production box that has
the mly controller in it, but unfortunately the source of the problems
seems to have disappeared and so I haven't seen any enclosure errors
again to verify that the output is what is expected.  If anybody can
test this patch by applying it and enerating any of the affected
enclosure errors involved, I'd appreciate it.

Uuencoded patch follows:

begin 644 mly_patch
M+2TM('-Y<R]D978O;6QY+VUL>2YC+F]R:6<)36]N($UA<B`@-2`Q-#HQ-SHR
M-"`R,#`Q"BLK*R!S>7,O9&5V+VUL>2]M;'DN8PE4:'4@1&5C(#(W(#$U.C0Y
M.C4Y(#(P,#$*0$`@+3<W-"PW("LW-S0L-R!`0`H@"2`@("!S8RT^;6QY7V)T
M;%MM92T^8VAA;FYE;%U;;64M/G1A<F=E=%TN;6)?9FQA9W,@?#T@34Q97T)4
M3%]215-#04X["B`)8G)E86L["B`@("`@8V%S92`G92<Z"BT);6QY7W!R:6YT
M9BAS8RP@='`L(&UE+3YT87)G970L(&UE+3YL=6XI.PHK"6UL>5]P<FEN=&8H
M<V,L(")E;F-L;W-U<F4@)60@+2`E<R`M(",E9%QN(BP@;64M/G1A<F=E="P@
M='`L(&UE+3YL=6XI.PH@"6)R96%K.PH@("`@(&-A<V4@)V,G.@H@"6UL>5]P
M<FEN=&8H<V,L(")C;VYT<F]L;&5R("5S7&XB+"!T<"D["BTM+2!S>7,O9&5V
M+VUL>2]M;'E?=&%B;&5S+F@N;W)I9PE4:'4@1&5C(#(W(#$U.C0V.C$P(#(P
M,#$**RLK('-Y<R]D978O;6QY+VUL>5]T86)L97,N:`E4:'4@1&5C(#(W(#$U
M.C4S.C(X(#(P,#$*0$`@+3(S-"PQ.2`K,C,T+#$Y($!`"B`@("`@>R)L("!R
M96%D(&]F(&1A=&$@8FQO8VL@:6X@8F1T(BP)"0D)"3!X,#`Y97TL"B`@("`@
M>R)L("!W<FET92!B86-K(&1A=&$@9F]R(&1I<VL@8FQO8VL@;&]S="(L"0D)
M"3!X,#`Y9GTL"B`@("`@+RH@96YC;&]S=7)E(&UA;F%G96UE;G0@979E;G1S
M("@P>#`Q,#`@+2`P>#`Q-V8I("HO"BT@("`@>R)E("!E;F-L;W-U<F4@)60@
M9F%N("5D(&9A:6QE9"(L"0D)"0DP>#`Q-#!]+`HM("`@('LB92`@96YC;&]S
M=7)E("5D(&9A;B`E9"!O:R(L"0D)"0DP>#`Q-#%]+`HM("`@('LB92`@96YC
M;&]S=7)E("5D(&9A;B`E9"!N;W0@<')E<V5N="(L"0D)"3!X,#$T,GTL"BT@
M("`@>R)E("!E;F-L;W-U<F4@)60@<&]W97(@<W5P<&QY("5D(&9A:6QE9"(L
M"0D)"3!X,#$T,WTL"BT@("`@>R)E("!E;F-L;W-U<F4@)60@<&]W97(@<W5P
M<&QY("5D(&]K(BP)"0D),'@P,30T?2P*+2`@("![(F4@(&5N8VQO<W5R92`E
M9"!P;W=E<B!S=7!P;'D@)60@;F]T('!R97-E;G0B+`D)"3!X,#$T-7TL"BT@
M("`@>R)E("!E;F-L;W-U<F4@)60@=&5M<&5R871U<F4@<V5N<V]R("5D(&9A
M:6QE9"(L"0D),'@P,30V?2P*+2`@("![(F4@(&5N8VQO<W5R92`E9"!T96UP
M97)A='5R92!S96YS;W(@)60@8W)I=&EC86PB+`D)"3!X,#$T-WTL"BT@("`@
M>R)E("!E;F-L;W-U<F4@)60@=&5M<&5R871U<F4@<V5N<V]R("5D(&]K(BP)
M"0DP>#`Q-#A]+`HM("`@('LB92`@96YC;&]S=7)E("5D('1E;7!E<F%T=7)E
M('-E;G-O<B`E9"!N;W0@<')E<V5N="(L"0DP>#`Q-#E]+`HM("`@('LB92`@
M96YC;&]S=7)E("5D('5N:70@)60@86-C97-S(&-R:71I8V%L(BP)"0D),'@P
M,31A?2P*+2`@("![(F4@(&5N8VQO<W5R92`E9"!U;FET("5D(&%C8V5S<R!O
M:R(L"0D)"3!X,#$T8GTL"BT@("`@>R)E("!E;F-L;W-U<F4@)60@=6YI="`E
M9"!A8V-E<W,@;V9F;&EN92(L"0D)"3!X,#$T8WTL"BL@("`@>R)E("!F86X@
M9F%I;&5D(BP)"0D)"0D),'@P,30P?2P**R`@("![(F4@(&9A;B!O:R(L"0D)
M"0D)"3!X,#$T,7TL"BL@("`@>R)E("!F86X@;F]T('!R97-E;G0B+`D)"0D)
M"3!X,#$T,GTL"BL@("`@>R)E("!P;W=E<B!S=7!P;'D@9F%I;&5D(BP)"0D)
M"0DP>#`Q-#-]+`HK("`@('LB92`@<&]W97(@<W5P<&QY(&]K(BP)"0D)"0DP
M>#`Q-#1]+`HK("`@('LB92`@<&]W97(@<W5P<&QY(&YO="!P<F5S96YT(BP)
M"0D)"3!X,#$T-7TL"BL@("`@>R)E("!T96UP97)A='5R92!S96YS;W(@9F%I
M;&5D(BP)"0D)"3!X,#$T-GTL"BL@("`@>R)E("!T96UP97)A='5R92!S96YS
M;W(@8W)I=&EC86PB+`D)"0D),'@P,30W?2P**R`@("![(F4@('1E;7!E<F%T
M=7)E('-E;G-O<B!O:R(L"0D)"0DP>#`Q-#A]+`HK("`@('LB92`@=&5M<&5R
M871U<F4@<V5N<V]R(&YO="!P<F5S96YT(BP)"0D),'@P,30Y?2P**R`@("![
M(F4@('5N:70@86-C97-S(&-R:71I8V%L(BP)"0D)"0DP>#`Q-&%]+`HK("`@
M('LB92`@=6YI="!A8V-E<W,@;VLB+`D)"0D)"3!X,#$T8GTL"BL@("`@>R)E
M("!U;FET(&%C8V5S<R!O9F9L:6YE(BP)"0D)"0DP>#`Q-&-]+`H@("`@("\J
M(&-O;G1R;VQL97(@979E;G1S("@P>#`Q.#`@+2`P>#`Q9F8I("HO"B`@("`@
M>R)C("!C86-H92!W<FET92!B86-K(&5R<F]R(BP)"0D)"3!X,#$X,7TL"B`@
M("`@>R)C("!B871T97)Y(&)A8VMU<"!U;FET(&9O=6YD(BP)"0D)"3!X,#$X
$.'TL"@``
`
end



--
 Chris Dillon - cdillon@wolves.k12.mo.us - cdillon@inter-linc.net
 FreeBSD: The fastest and most stable server OS on the planet
 - Available for IA32 (Intel x86) and Alpha architectures
 - IA64, PowerPC, UltraSPARC, and ARM architectures under development
 - http://www.freebsd.org

Comment 2 Sheldon Hearn 2002-01-09 12:42:52 UTC

Responsible Changed
From-To: freebsd-bugs->msmith

Over to the Mylex driver maintainer.  If he's happy with the patch, 
I can commit it for him, but for now, the ball is in his court.

On Wed, 26 Dec 2001, Chris Dillon wrote:

> >Number:         33202
> >Category:       kern
> >Synopsis:       sys/dev/mly/mly.c minor mly_printf cosmetic problem

Hmm...  I just noticed that GNATS didn't attach the message I sent a
while back with the revised patch in it to the audit trail.  Let's
hope it attaches this one.  The message containing the revised patch
has the following Message-ID:

<Pine.BSF.4.32.0112301857120.45706-100000@mail.wolves.k12.mo.us>

--
 Chris Dillon - cdillon@wolves.k12.mo.us - cdillon@inter-linc.net
 FreeBSD: The fastest and most stable server OS on the planet
 - Available for IA32 (Intel x86) and Alpha architectures
 - IA64, PowerPC, UltraSPARC, and ARM architectures under development
 - http://www.freebsd.org

Comment 4 Scott Long 2003-02-11 06:36:53 UTC

State Changed
From-To: open->closed

The simplest way to resolve this is to just do an explicit 'printf("n");' 
after the mly_printf().  Fixed.