Bug 33641

Summary:	http://www.freebsd.org/cgi/gallery.cgi gives weird preview
Product:	Documentation	Reporter:	edwin
Component:	Books & Articles	Assignee:	freebsd-doc (Nobody) <doc>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description edwin 2002-01-07 10:30:01 UTC

If you fill in an organisation, description and URL and press
preview, the </a> at thge end of the Organization goes though on
the description.

Fix: 

none
How-To-Repeat: 
See description

Comment 1 darklogik 2002-01-08 01:32:51 UTC

Reading over this pr, I always thought this was how the FreeBSD team 
wanted it to work.  However, I have tried this, its true that after the 
preview button is pressed, the next page links the description as part 
of the link (ie clickable).  Maybe it should stay like that, cause final 
processing looks fine to me (under the gallery.html) and the only person 
who sees this is the submitter.

Tom (Darklogik) Rhodes
www.Pittgoth.com -Gothic Liberation Front
www.FreeBSD.org -The Power To Serve

Comment 2 Peter Pentchev 2002-01-08 12:23:40 UTC

On Mon, Jan 07, 2002 at 05:30:01PM -0800, Tom Rhodes wrote:
> The following reply was made to PR docs/33641; it has been noted by GNATS.
> 
> From: Tom Rhodes <darklogik@pittgoth.com>
> To: freebsd-gnats-submit@FreeBSD.org
> Cc:  
> Subject: Re:docs/33641  Was it not designed to work this way?
> Date: Mon, 07 Jan 2002 20:32:51 -0500
> 
>  Reading over this pr, I always thought this was how the FreeBSD team 
>  wanted it to work.  However, I have tried this, its true that after the 
>  preview button is pressed, the next page links the description as part 
>  of the link (ie clickable).  Maybe it should stay like that, cause final 
>  processing looks fine to me (under the gallery.html) and the only person 
>  who sees this is the submitter.

Still, no harm in fixing gallery.cgi so that it displays the entry
exactly as it would be posted later :)  Patch attached.

G'luck,
Peter

-- 
If the meanings of 'true' and 'false' were switched, then this sentence wouldn't be false.

Index: www/en/cgi/gallery.cgi
===================================================================
RCS file: /home/ncvs/www/en/cgi/gallery.cgi,v
retrieving revision 1.19
diff -u -r1.19 gallery.cgi
--- www/en/cgi/gallery.cgi	24 Oct 2001 17:29:39 -0000	1.19
+++ www/en/cgi/gallery.cgi	8 Jan 2002 12:03:37 -0000
@@ -22,8 +22,8 @@
 require 'cgi-style.pl';
 
 # Construct the gallery entry in HTML form
-$entry = "<li><a href=\"$in{'url'}\"><strong>$in{'organization'}</strong> " .
-    "-- $in{'description'}</a></li>";
+$entry = "<li><a href=\"$in{'url'}\"></a><strong>$in{'organization'}</strong>".
+    " -- $in{'description'}</li>";
 
 # Try and figure out where the person came from so we can provide
 # links back to the correct place.

Comment 3 Alexey Zelkin freebsd_committer

2002-01-08 15:32:16 UTC

State Changed
From-To: open->closed

Fixed. Thanks!