Bug 34591

Summary: ICMP bandwidth limiting does not indicate interface
Product: Base System Reporter: Eric Hodel <drbrain>
Component: kernAssignee: Andre Oppermann <andre>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Eric Hodel 2002-02-03 20:30:01 UTC 
When limiting the ICMP responses, the interface upon which the
bandwidth is being limited is not displayed. For a machine with
multiple interfaces, the administrator will have to employ other
tools to determine which interface is affected

Fix: Send the interface name and number to badport_bandlim and display
them in the message like this:

Limiting closed port RST response from 470 to 200 packets per second on lo0

The attache patch adds this functionality
How-To-Repeat: nmap localhost

Will display the following message on the console:
Limiting closed port RST response from 470 to 200 packets per second

nmap can be installed from /usr/ports/security/nmap
Comment 1 Crist J. Clark freebsd_committer freebsd_triage 2002-02-07 01:46:30 UTC 
On Sun, Feb 03, 2002 at 12:23:35PM -0800, Eric Hodel wrote:
[snip]

> >Description:
> When limiting the ICMP responses, the interface upon which the
> bandwidth is being limited is not displayed. For a machine with
> multiple interfaces, the administrator will have to employ other
> tools to determine which interface is affected

The patch is somewhat bogus since right now, the limiting has nothing
to do with interfaces. That is, if you have a 200 limit and there are
75 packets on if0, 75 packets on if1, and 75 packets on if2, you'll
hit the limit. But which one should be displayed in the message? There
is also the situation where there is a storm on if0, but a ICMP
message from if1, where there is a low bandwidth, happens to trip the
alarm.

Now how often do situations like that happen? I really couldn't
say. The patches provide a first approximation of the interface with
the trouble, but can actually provide false information which I think
may be more trouble than its worth.
-- 
Crist J. Clark                     |     cjclark@alum.mit.edu
                                   |     cjclark@jhu.edu
http://people.freebsd.org/~cjc/    |     cjc@freebsd.org
Comment 2 Andre Oppermann freebsd_committer freebsd_triage 2003-12-27 16:38:34 UTC 
State Changed
From-To: open->analyzed

Take over.
Comment 3 Andre Oppermann freebsd_committer freebsd_triage 2003-12-27 16:38:34 UTC 
Responsible Changed
From-To: freebsd-bugs->andre

Take over.
Comment 4 Andre Oppermann freebsd_committer freebsd_triage 2005-09-14 17:39:46 UTC 
State Changed
From-To: analyzed->closed

ICMP bandwidth limiting is a global function, not per interface. 
Thus is doesn't make sense to print the ifp of the packet tripping 
into the limiter.  We don't have any plans to change limiting to 
be per interface.