Bug 34795

Summary: Deprecated uudecode option used during 'make world'
Product: Base System Reporter: Szilveszter Adam <sziszi>
Component: miscAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   

Description Szilveszter Adam 2002-02-10 16:50:00 UTC
When any of the COMPAT1X etc options are set in /etc/make.conf, the
appropriate set of compat libraries will be uudecoded and gunzipped
during the make buildworld process from under src/lib/compat.

Recently, in rev1.17 of src/usr.bin/uudecode/uudecode.c the "-p"
option was deprecated (and "-o /dev/stdout" suggested instead.) This
change has not been MFCd so only -CURRENT is affected for now.

The Makefiles under src/lib/compat failed to take into account this
change and still try to use the "-p" option to uudecode. This is not
(yet) fatal as I see, but produces a warning and should be fixed
before "-p" support is removed.

Fix: 

Easy: swap any invocation of "uudecode -p" in the Makefiles under
src/lib/compat for "uudecode -o dev/stdout". BTW I think those
invocations are not very elegant; there is quite some duplication
there and the value of uudecode is hardwired.
How-To-Repeat: 	
Set any of the COMPAT1X etc variables in /etc/make.conf and use 'make world'
or 'make release'. Or cd to src/lib/compat directly and "make obj &&
make && make install"
Comment 1 Szilveszter Adam 2002-02-16 21:37:44 UTC
Hello,

Sorry to follow up on my own PR. The "-p" option to uudecode was
un-deprecated today, so this "fixes" the problem in a quick way.:-)

This PR can now be closed.
-- 
Regards:

Szilveszter ADAM
Szombathely Hungary
Comment 2 Maxim Konovalov freebsd_committer freebsd_triage 2002-02-16 21:45:07 UTC
State Changed
From-To: open->closed

uudecode(1)'s "-p" option is un-deprecated in ver.1.18. Closed by 
submitter request, thanks!