Bug 34863

Summary: port apache13-fp broken
Product: Ports & Packages Reporter: Joseph Barbish <barbish>
Component: Individual Port(s)Assignee: Ade Lovett <ade>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Joseph Barbish 2002-02-12 07:10:00 UTC
In general the following 7 problems are totaly due to very poor testing by the port maintainer. 

1. The frontpage security patch which was just added in the last 3 days is generating this error message in the httpd-error.log.
The key file /usr/local/frontpage/version5.0/apache-fp/suidkey does not exist in frontpage(). Frontpage security patch is disabled. 

2. After the install is completed (ie before problem #1 came into play) the frontpage extentions are not active, and can not be activated unless the if statments before and after the dso loadmodule statment for the frontpage-module are commented out in httpd.conf.

3. The fp-install.sh script will not install frontpage extentions unless the two httpd-conf allowoverride none statments are changed to allowoverride all before the fp-install.sh script is run.

4. The fp-install.sh script asks for the frontpage adminstrators id and defaults to fpadmin. Script will not accept any value typed in. Can not change the default from fpadmin.

5. Two files are defined in the httpd.conf file but not allocated and cause apache not to start. 
/usr/local/etc/apache/mine.types 
/usr/local/etc/apache/magic

6. The frontpage web server extentions web site that allows the frontpage adminstrator to use a web browser to control and change the frontpage enviornment is not configurated into httpd.conf file. You can see it at /usr/local/frontpage/version5.0/admin

7. All frontpage user defined web sites show up as a directory tree when viewed from a web browser instead of just the web content.

Fix: 

problem #1. Somebody needs to supervice the person who is maintaining  mod_frontpage so he can not just dump changes into the production port system without doing complete testing all the way through to testing the finished apache/fp enviroment. There is more to creating a port that just makeing the makefile.

problem #2.  Research why the if statments are not being activated or remove them from the model httpd.conf file which is part of the port.

problem #3. Change the two allowoverride none ststments in the model httpd.conf file which is part of the port so they are correct when the first fp-install.sh is run as part of the make install process.

problem #4. Research the fp-install.sh script to determin and fix so the default frontpage id can be changed.

problem #5. Find the 2 missing files in the orginal fp extentions source and change what ever you have to, to get the files created and the correct content loaded into them as part of the port. 

problem #6. The frontpage extentions web site content is being installed as part of the port, but it is not being configured so it can be used after the make install is completed. Research why this is happening and correct.

problem #7. Research and correct.
How-To-Repeat:     Try to install the port your self.
Comment 1 Scot W. Hetzel 2002-02-13 05:31:00 UTC
> In general the following 7 problems are totaly due to very poor testing by
the port maintainer.
>
> 1. The frontpage security patch which was just added in the last 3 days is
generating this error
> message in the > httpd-error.log. The key file
/usr/local/frontpage/version5.0/apache-fp/suidkey
>  does not exist in frontpage().  Frontpage security patch is disabled.
>
This is caused by not using the /usr/local/etc/rc.d/apache.sh script to
start the apache-fp server.  The script re-creates the suidkey each time it
is run. This adds to the security of the FP Exts, as the key is changed each
time the server is restarted.

> 2. After the install is completed (ie before problem #1 came into play)
the frontpage extentions
> are not active, and can not be activated unless the if statments before
and after the dso
> loadmodule statment for the frontpage-module are commented out in
httpd.conf.
>
Again, the use of the /usr/local/etc/rc.d/apache.sh script uses:

    apachectl start_FP

Which the apachectl program converts to -DMOD_FP, when starting the apache
server.

> 3. The fp-install.sh script will not install frontpage extentions unless
the two httpd-conf
> allowoverride none statments are changed to allowoverride all before the
fp-install.sh
> script is run.
>
The installed httpd.conf file already has the AllowOverride Directive
changed to "AuthConfig Limit Indexes Options" for the PREFIX/www/data
directory.  The fp_install.sh script has no problems with the httpd.conf
file.  If you have a httpd.conf file installed from one of the other apache
ports, then the script will fail.

> 4. The fp-install.sh script asks for the frontpage adminstrators id and
defaults to fpadmin.
> Script will not accept any value typed in. Can not change the default from
fpadmin.
>
The script does accept other values for the frontpage administrator:

    :
    Installing the root web...

    Server config filename:  [/usr/local/etc/apache/httpd.conf]
    FrontPage Administrator's user name:  [fpadmin] newuser

    Getting User from /usr/local/etc/apache/httpd.conf
    Unix user name of the owner of this new web: [www]
    :

    #cat /usr/local/www/data/_vti_pvt/services.grp
    # -FrontPage-
    administrators: newuser
    authors:

> 5. Two files are defined in the httpd.conf file but not allocated and
cause apache not to start.
> /usr/local/etc/apache/mine.types
> /usr/local/etc/apache/magic
>
I came across this problem today, I'll have to find out why
mime.types.default & magic.default are not being copied to these two files.

> 6. The frontpage web server extentions web site that allows the frontpage
adminstrator to use a
> web browser to control and change the frontpage enviornment is not
configurated into httpd.conf
> file. You can see it at /usr/local/frontpage/version5.0/admin
>
The "Site Administration Pages"
(http://servername/_vti_bin/_vti_adm/fpadmcgi.exe) are active when the
apache13-fp port is installed, the only thing that is not activated is the
"Server Administration Pages" (http://servername:port/fpadmcgi.exe [port >
1023]).  These pages require the server admin to run the owsadm.exe to setup
access to these pages.

> 7. All frontpage user defined web sites show up as a directory tree when
viewed from a web
> browser instead of just the web content.
>
I can't reproduce this problem.

So the only problem I see with the apache13-fp/frontpage ports is problem 5
mime.types and magic not being installed, and a feature request to add
support for the "Server Administration Pages" in problem 6.

For the feature request, I'll have to fix the fp_install.sh script
(frontpage port) to setup the "Server Administration Pages" and to add a
virtual host entry to httpd.conf (apache13-fp port).

Scot
Comment 2 Joseph Barbish 2002-02-17 02:50:40 UTC
In reference to the comments posted by this port maintainer. 
All the confusion about which script to use to start the 
apache/fp server can be eliminated by posting clear and 
simple step by step startup instructions in the pkg_message file.
First time users of this port need instructions about what to do 
to get it to work. So please make user instructions part of the port.
It would also help if the description of the port contained more 
information about what functions of FrontPage were contained in the port.
Comment 3 Joseph Barbish 2002-02-17 02:52:52 UTC
For the week of 2/10/02-02/16/02 the apache13-fp port has been broken.
Just tried to install apache13-fp port again today 2/16/02.
The install went fine until fp50.freebsd.tar.Z completed
downloading. While the process was trying to install,
it issued the following  messages.

Receiving fp50.freebsd.tar.Z (15449019 bytes): 100%
15449019 bytes transferred in 6622.9 seconds (2.28 kBps)
===>  Extracting for frontpage-5.0.2.2623_1
>> Checksum OK for fp50.freebsd.tar.Z.
===>   frontpage-5.0.2.2623_1 depends on shared library: c.3 - found
===>  Extracting FrontPage install scripts
cd /usr/ports/www/frontpage/work &&  /usr/bin/gzip -nf -9 -dc
/usr/ports/distfil
es/fp50.freebsd.tar.Z  | /usr/bin/tar -xf -
frontpage/version5.0/fp_install.sh f
rontpage/version5.0/apache-fp/fpexe.c  frontpage/version5.0/readme.htm
frontpage
/version5.0/set_default_perms.sh
===>  Patching for frontpage-5.0.2.2623_1
===>  Applying FreeBSD patches for frontpage-5.0.2.2623_1
No file to patch.  Skipping...
13 out of 13 hunks ignored--saving rejects to fp_install.sh.rej
>> Patch patch-fp_install.sh failed to apply cleanly.
*** Error code 1
Stop in /usr/ports/www/frontpage.
*** Error code 1
Comment 4 Ade Lovett freebsd_committer freebsd_triage 2002-03-13 01:16:11 UTC
State Changed
From-To: open->feedback

From the Audit-Trail, it appears that the port MAINTAINER is working with 
you, so I'll put this in feedback, awaiting further instructions. 


Comment 5 Ade Lovett freebsd_committer freebsd_triage 2002-03-13 01:16:11 UTC
Responsible Changed
From-To: freebsd-ports->ade

I'll track this.
Comment 6 Joseph Barbish 2002-03-26 04:49:24 UTC
3/25//2002
I checked the change log and it's been 8 weeks since the last change.
That's before my PR report. Nothing has been done to correct the problems.

When it comes the what he says is a feature request I call a very big
omission.

The Server Administration Pages he is referring to are the FrontPage Server
Administration Pages apache web site. I can not understand why these were
not
included when the port was originally created. Why force the user to use the
ms/FrontPage client on the pc to create apache web sites when there is an
apache web FrontPage server admin pages to do it direct to apache that is
provided as part of the ms Unix FrontPage extensions. This is a
very user friendly tool that makes the creation of and control of FrontPage
web site very easy. This is like half of the FrontPage port is missing. Sure
the
port will function with out it, but why leave it out or make it so hard to
get it working?

The problem with the mime.types and magic files not being installed, turns
out
that the files are there but have a suffix of default on their names. The
fix is
to change the httpd.conf control statements to point to these files by
appending
the word default to the end of the file names.

Now the pkg_commments file is the vehicle for passing last minute
configuration
information on to the user. Why not add some comments to that file telling
the
user that the port will not work as installed from the port. That there are
2
files with the incorrect names and how to fix it. Also some verbiage about
not
using the standard apache start script but the apache13-fp start script and
where to find it. I also believe the script to setup/add the apache web
sites
must also now use the apache13-fp script and not the standard apach13
script.
Again give location to find correct script.

I know it's all volunteer's but why not take some pride in a job well done.

The FBSD minimum documentation standard is just not acceptable by us users.

You folks holding the controls have to do something about ports going in
with
out 3rd part testing. Omission and errors like this would be caught. I even
volunteered to the maintainer to work with him to test his corrections and
he
ignored my offer. What more can a user do?


Maintainers statements.
So the only problem I see with the apache13-fp/frontpage ports is problem 5
 mime.types and magic not being installed, and a feature request to add
 support for the "Server Administration Pages" in problem 6.

 For the feature request, I'll have to fix the fp_install.sh script
 (frontpage port) to setup the "Server Administration Pages" and to add a
 virtual host entry to httpd.conf (apache13-fp port).
Comment 7 Ade Lovett freebsd_committer freebsd_triage 2002-04-12 20:23:17 UTC
State Changed
From-To: feedback->closed

Timeout (1 month) in feedback.