Bug 35879

Summary: autoconf-2.52_2 creates empty case/esac statements
Product: Ports & Packages Reporter: James Flemer <jflemer>
Component: Individual Port(s)Assignee: Alan Eldridge <alane>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description James Flemer 2002-03-14 02:10:01 UTC
The autoconf port should be patched for this bug, or upgraded to 2.53.
There was a patch[1] posted to the GNU autoconf mailing list.
This is not a very critical bug, and I assume that the port will move to
2.53 soon anyway, but in the mean time, the patch should fix the problem.

[1] http://www.geocrawler.com/mail/msg.php3?msg_id=7758332&list=402

Fix: 

Patch available at:

http://www.geocrawler.com/mail/msg.php3?msg_id=7758332&list=402
How-To-Repeat: $ cat > configure.ac
AC_INIT(test, 0)
AC_PREREQ(2.52)
AC_CONFIG_COMMANDS(default, , [echo hi there])
AC_OUTPUT
$ autoconf
$ ./configure
configure: creating ./config.status
hi there
./config.status: 233: Syntax error: "done" unexpected (expecting ")")
Comment 1 Pete Fritchman freebsd_committer freebsd_triage 2002-03-14 03:27:55 UTC
Responsible Changed
From-To: freebsd-ports->portmgr

Over to maintainers
Comment 2 Akinori MUSHA 2002-03-14 08:37:01 UTC
At Wed, 13 Mar 2002 18:09:06 -0800 (PST),
James Flemer wrote:
> >Synopsis:       autoconf-2.52_2 creates empty case/esac statements

> The autoconf port should be patched for this bug, or upgraded to 2.53.
> There was a patch[1] posted to the GNU autoconf mailing list.
> This is not a very critical bug, and I assume that the port will move to
> 2.53 soon anyway, but in the mean time, the patch should fix the problem.

I definitely agree that autoconf should be upgraded to 2.53.  2.52 has
many bugs that get some pieces of software to build incorrectly or
fail, and leaving devel/autoconf at 2.52 is preventing some ports
upgrades because of the bugs or requiring some ports to add local
hacks.

Try the following patch that updates the port to 2.53, in which
version those problems are fixed (including the one I submitted):

	http://www.iDaemons.org/~knu/tmp/devel_autoconf_2.53.patch

Although the 2.52 -> 2.53 update loses some backward compatibility in
a few respects (e.g. AC_LIBOBJ vs. LIBOBJS), most vendors will fix
their products and thus we can cope with problems by updating
problematic ports one by one.

Portmgr, please test it and update the devel/autoconf port soon.

Regards,

-- 
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"Somewhere out of a memory.. of lighted streets on quiet nights.."
Comment 3 James Flemer 2002-03-14 14:19:13 UTC
That looks good. I wrote essentially the same patch myself
last night (except it used the tar, not the bz2), and it
works fine. I'm not certain, but shouldn't the pkg-plist
have:

@exec install-info %D/info/autoconf.info %D/info/dir
@exec install-info %D/info/standards.info %D/info/dir

I noticed the Makefile in work/autoconf-2.53/doc runs
install-info, but if this port is made into a package,
install-info won't be run w/o the two lines above, right?
-James
Comment 4 Akinori MUSHA 2002-03-14 14:53:04 UTC
At Thu, 14 Mar 2002 09:19:13 -0500 (EST),
James E. Flemer <jflemer@acm.jhu.edu> wrote:
> That looks good. I wrote essentially the same patch myself
> last night (except it used the tar, not the bz2), and it
> works fine. I'm not certain, but shouldn't the pkg-plist
> have:
> 
> @exec install-info %D/info/autoconf.info %D/info/dir
> @exec install-info %D/info/standards.info %D/info/dir
> 
> I noticed the Makefile in work/autoconf-2.53/doc runs
> install-info, but if this port is made into a package,
> install-info won't be run w/o the two lines above, right?

Thanks, just fixed. :)

-- 
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"Somewhere out of a memory.. of lighted streets on quiet nights.."
Comment 5 Dan Nelson 2002-09-23 00:57:27 UTC
Note that there is nothing wrong with autoconf; an empty case block is
perfectly valid according to SUSV2:

case_clause      : Case WORD linebreak in linebreak case_list    Esac
                 | Case WORD linebreak in linebreak case_list_ns Esac
                 | Case WORD linebreak in linebreak              Esac

The bug is really in our ash.  Empty cases parse just fine on Debian's
ash, and Solaris & Tru64's bourne.
Comment 6 Tilman Keskinoz freebsd_committer freebsd_triage 2002-10-20 17:52:44 UTC
Responsible Changed
From-To: portmgr->alane

AlanE has volunteered to maintain autoconf.
Comment 7 Alan Eldridge freebsd_committer freebsd_triage 2002-10-20 21:16:44 UTC
State Changed
From-To: open->closed

Submitter is way behind times. Current autoconf *is* 2.53.