Bug 36097

Martin Karlsson wrote:

I apologize, and never like to be critical, but the patch

I got removes text, and never adds anything, is this on purpose?

Also, could you perhaps use diff -ru dir.old dir.new > dir.diff, it 
makes it a bit easier to apply your patches.

Thanks for taking the time to help us :)

> 
> 	 
> *** 2book.sgml	Tue Mar 19 14:02:44 2002
> --- book.sgml	Tue Mar 19 13:58:17 2002
> ***************
> *** 8033,8051 ****
>         </qandaentry>
>   
>         <qandaentry>
> -         <question id="xfree86-version">
> -           <para>An X app I am building depends on XFree86 3.3.*, but I 
> - 	    have XFree86 4.* installed. What should I do?</para>
> -         </question>
> - 
> -         <answer>
> -           <para>Add the following to <filename>/etc/make.conf</filename>, (if you 
> - 	    do not have this file, create it):</para>
> -             <programlisting>XFREE86_VERSION=        4</programlisting>
> -         </answer>
> -       </qandaentry>
> - 
> -       <qandaentry>
>           <question id="mouse-button-reverse">
>             <para>How do I reverse the mouse buttons?</para>
>           </question>
> --- 8033,8038 ----
> 


-- 
Tom (Darklogik) Rhodes
www.Pittgoth.com Gothic Liberation Front
www.FreeBSD.org  The Power To Serve

* Tom Rhodes <darklogik@pittgoth.com> [2002-03-19 10.59 -0500]:
> Martin Karlsson wrote:
> 
> I apologize, and never like to be critical, but the patch
> 
> I got removes text, and never adds anything, is this on purpose?
 
No, this was not the intended behaviour. I believe this could serve
as a prototype example of a screw-up. I really am very sorry.

I hope this one (new, below) is alright. *smiles feebly* It does apply
cleanly here, but as I may have shown, I am a _newbie_ at this,
so... Anyway, after having applied it here, 'diff book.old book.new'
produces nothing, so I _think_ it'll be alright.

> Also, could you perhaps use diff -ru dir.old dir.new > dir.diff, it 
> makes it a bit easier to apply your patches.
 
Sure. Will do.

> Thanks for taking the time to help us :)

Hey, thanks for setting me straight on this. I really appreciate
that.  Please get in touch with me if something should come up, I
want to get this right.

Regards,
-- 
Martin, who should learn to RTFM

---8<--------------8<--------------------8<---------------------


--- book.old	Tue Mar 19 13:58:17 2002
+++ book.new	Tue Mar 19 14:02:44 2002
@@ -8033,6 +8033,19 @@
       </qandaentry>
 
       <qandaentry>
+        <question id="xfree86-version">
+          <para>An X app I am building depends on XFree86 3.3.*, but I 
+	    have XFree86 4.* installed. What should I do?</para>
+        </question>
+
+        <answer>
+          <para>Add the following to <filename>/etc/make.conf</filename>, (if you 
+	    do not have this file, create it):</para>
+            <programlisting>XFREE86_VERSION=        4</programlisting>
+        </answer>
+      </qandaentry>
+
+      <qandaentry>
         <question id="mouse-button-reverse">
           <para>How do I reverse the mouse buttons?</para>
         </question>

Comment 3 chern 2002-03-25 10:21:07 UTC

State Changed
From-To: open->closed

Committed, thanks!