Bug 36153

Summary:	/usr/src/games/fortune/README instructions for including offensive fortunes don't work.
Product:	Base System	Reporter:	Nick Jennings <nick>
Component:	misc	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	4.5-RELEASE
Hardware:	Any
OS:	Any

Description Nick Jennings 2002-03-21 03:20:01 UTC

This could be related to bug 'misc/36152', though I am not sure.

The README file (/usr/src/games/fortune/README) says, to enable offensive fortunes "whack" the Makefile located in datfiles/ subdirectory.(by "whack" i assume delete).

However, when I do this, and run a 'make all' there are errors.
# rm datfiles/Makefile
# make all
===> fortune
Warning: Object directory not changed from original /usr/src/games/fortune/fortune
===> strfile
Warning: Object directory not changed from original /usr/src/games/fortune/strfile
===> datfiles
make: don't know how to make all. Stop
*** Error code 2

Stop in /usr/src/games/fortune.
#

This error does not occur when the datfiles/Makefile exists.

How-To-Repeat: remove the datfiles/Makefile and try to compile.

Comment 1 Kris Kennaway 2002-03-21 04:58:47 UTC

On Wed, Mar 20, 2002 at 07:11:31PM -0800, Nick Jennings wrote:

> The README file (/usr/src/games/fortune/README) says, to enable
> offensive fortunes "whack" the Makefile located in datfiles/
> subdirectory.(by "whack" i assume delete).

No, it seems to mean "edit".

> However, when I do this, and run a 'make all' there are errors.

Well, yeah :)

Kris

Comment 2 Nick Jennings 2002-03-21 05:37:21 UTC

On Wed, Mar 20, 2002 at 08:58:47PM -0800, Kris Kennaway wrote:
> On Wed, Mar 20, 2002 at 07:11:31PM -0800, Nick Jennings wrote:
> 
> > The README file (/usr/src/games/fortune/README) says, to enable
> > offensive fortunes "whack" the Makefile located in datfiles/
> > subdirectory.(by "whack" i assume delete).
> 
> No, it seems to mean "edit".
> 

 Hmm, maybe the README should be a little more descriptive?

 Also, perhaps this related to bug 'misc/36152' and once the
 datfiles/Makefile is fixed for that bug it will become cleaer what
 part of it needs editing to enable offensive fortunes?

 Either way, comments in the datfiles/Makefile or README, pointing 
 out what to change would be helpful :)

-- 
  Nick Jennings

Comment 3 Johan Karlsson freebsd_committer

2002-07-24 03:51:31 UTC

Hi

The offensive fortunes are installed by default on FreeBSD systems.
To see them invoke fortune with the -o option.

The README is incorrect in this aspect and should be changed.

/Johan K
-- 
Johan Karlsson		mailto:johan@FreeBSD.org

Comment 4 Jens Schweikhardt freebsd_committer

2002-09-24 19:48:28 UTC

State Changed
From-To: open->closed

No, whacking does not mean removing (we'd call that "nuking"). The 
README you refer to is outdated and the offensive fortunes are installed 
by default; the whacking refers to the following snippet from 
datfiles/Makefile: 

... 
# TO AVOID INSTALLING THE POTENTIALLY OFFENSIVE FORTUNES, COMMENT OUT THE 
# THREE LINES AND UNCOMMENT THE FOURTH LINE. 

# THE THREE LINES: 
FILES+= fortunes2-o limerick murphy-o 
BLDS+=  fortunes2-o.dat limerick.dat murphy-o.dat 
TYPE=   real 

# THE FOURTH LINE: 
#TYPE=  fake