Bug 37888

Summary: net/samba: fix vfs module support - restore recycle bin
Product: Ports & Packages Reporter: Scot W. Hetzel <hetzels>
Component: Individual Port(s)Assignee: dwcjr
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Scot W. Hetzel 2002-05-09 17:10:01 UTC 
	Previous to Samba 2.2.4, the port had a recycle bin function.
	This was removed when the port was updated.  The site that hosts
	the recycle bin patches are currently not up todate, also it
	has been ported to a vfs module in 2.2.4.

Fix: The attached patch adds the recycle bin function back into the
	port, as well as updates the smb.conf.default to the latest version.

	changed files:
		Makefile
		pkg-plist
		files/README.FreeBSD    - There is no Chinese Samba port
		files/patch-*           - Changed due to addition of PATCH_WRKSRC
		files/patch-ba		- Addition of check for libc, as well as
		                          defining DYNEXP="-Wl,--export-dynamic" for
		                          the bsd case (needed for VFS modules)
		files/smb.conf.default  - Updated for 2.2.4, as well as add example
		                          entry for the recycle VFS module.

	New files:
		files/patch-examples-VFS-Makefile     - Add missing ../source/popt to includes
		files/patch-examples-VFS-recycle.c    - fixes a NULL pointer + 1 bug, caused
		                                        by strrchr returning a NULL when '/'
		                                        is not found
		files/patch-source-include-includes.h

	Removed file:
		files/patch-include-includes.h	- renamed to patch-source-include-includes.h
Comment 1 Ying-Chieh Liao freebsd_committer freebsd_triage 2002-05-09 17:41:37 UTC 
Responsible Changed
From-To: freebsd-ports->dwcjr

over to maintainer
Comment 2 dwcjr 2002-05-09 17:48:59 UTC 
I was under the impression that freebsd did not support dlopen, which is 
why we can't support winbindd for samba either?

Thanks for the patch, I'll take a look at it shortly.
Comment 3 dwcjr 2002-05-09 18:15:03 UTC 
I get this when I compile, any ideas?

checking for poptGetContext in -lpopt... yes
checking whether to use included popt... no
checking configure summary... ERROR: No locking available. Running Samba 
would be unsafe
configure: error: summary failure. Aborting config
===>  Script "configure" failed unexpectedly.
       Please report the problem to dwcjr@FreeBSD.org [maintainer] and 
attach
       the
 
"/.amd_mnt/leviathan/host/usr/home/poseiden/port/samba/work/samba-2.2.4/source/config.log"
       including the output of the failure of your make command. Also, 
it might
       be a good idea to provide an overview of all packages installed 
on your
       system (e.g. an `ls /var/db/pkg`).
*** Error code 1
Comment 4 Scot W. Hetzel 2002-05-09 19:31:56 UTC 
From: "David W. Chapman Jr." <dwcjr@inethouston.net>
> I get this when I compile, any ideas?
>
> checking for poptGetContext in -lpopt... yes
> checking whether to use included popt... no
> checking configure summary... ERROR: No locking available. Running Samba
> would be unsafe
> configure: error: summary failure. Aborting config
> ===>  Script "configure" failed unexpectedly.

When I configure I get the following:

:
checking for poptGetContext in -lpopt... no
checking whether to use included popt... ./popt
checking configure summary... yes
updating cache ./config.cache
:

The only difference that I can see is that you have the popt library
installed.

Also, when I compiled I used the following port flags:

    make -DWITH_RECYCLE -DWITH_QUOTAS \
             -DWITH_UTMP -DWITH_MSDFS \
             -DWITH_SSL -DWITHOUT_CUPS configure

I have placed the config.log on our web server, it is available at:

    http://www.westbend.net/~hetzels/samba-config.log

Hopefully this will help.

Scot
Comment 5 dwcjr freebsd_committer freebsd_triage 2002-05-10 14:43:49 UTC 
State Changed
From-To: open->closed

Committed, thanks!!!!!