Bug 37943

Comment 1 Giorgos Keramidas 2002-05-11 10:27:02 UTC

The majority of the changes look fine.  Where I am commenting below,
there are a few fine points I was thinking about.

On 2002-05-11 00:46, Martin Heinen wrote:
> -      <para>The most recent example of this is when the <quote/ppp/ group
> -	(later renamed <quote/network/) was added.  Users had the
> +      <para>The most recent example of this is when the <groupname>ppp</groupname> group
> +	(later renamed <groupname>network</groupname>) was added.  Users had the

This is also touched by patches of another PR I was reading.  One
submitted by Greg Shapiro.  If someone commits this one or the diff I
sent in the audit trail of that PR a little merging work will be
necessary for this part ;)

> -          Pentium 3 with 128 MB of RAM takes about 2 hours to build
> +          Pentium III with 128 MB of RAM takes about 2 hours to build

Is this really necessary?  I'm not saying it's wrong or something.
But is III the way these processors should be referred to in written
text?

Giorgos Keramidas                       FreeBSD Documentation Project
keramida@{freebsd.org,ceid.upatras.gr}  http://www.FreeBSD.org/docproj/

On Sat, May 11, 2002 at 12:27:02PM +0300, Giorgos Keramidas wrote:
> The majority of the changes look fine.  Where I am commenting below,
> there are a few fine points I was thinking about.
> 
> On 2002-05-11 00:46, Martin Heinen wrote:
> > -      <para>The most recent example of this is when the <quote/ppp/ group
> > -	(later renamed <quote/network/) was added.  Users had the
> > +      <para>The most recent example of this is when the <groupname>ppp</groupname> group
> > +	(later renamed <groupname>network</groupname>) was added.  Users had the
> 
> This is also touched by patches of another PR I was reading.  One
> submitted by Greg Shapiro.  If someone commits this one or the diff I
> sent in the audit trail of that PR a little merging work will be
> necessary for this part ;)

As Greg noted, this section needs some work.  Therefore we can drop
my suggestions and use PR 36773 instead.

> > -          Pentium 3 with 128 MB of RAM takes about 2 hours to build
> > +          Pentium III with 128 MB of RAM takes about 2 hours to build
> 
> Is this really necessary?  I'm not saying it's wrong or something.
> But is III the way these processors should be referred to in written
> text?

I compared with Intels Website:

  http://www.intel.com/products/browse/processor.htm?iid=ipp_nav+browse_proc&

According to this page it's Pentium III (note the Pentium 4 !).

-- 
Marxpitn

Comment 3 Giorgos Keramidas 2002-05-11 14:01:46 UTC

On 2002-05-11 13:09, Martin Heinen wrote:
> > This is also touched by patches of another PR I was reading.  One
> > submitted by Greg Shapiro.  If someone commits this one or the diff I
> > sent in the audit trail of that PR a little merging work will be
> > necessary for this part ;)
>
> As Greg noted, this section needs some work.  Therefore we can drop
> my suggestions and use PR 36773 instead.

If Greg says 'aye' to that other patch, I'll do the merge of the two :>

> > > -          Pentium 3 with 128 MB of RAM takes about 2 hours to build
> > > +          Pentium III with 128 MB of RAM takes about 2 hours to build
> >
> > Is this really necessary?  I'm not saying it's wrong or something.
> > But is III the way these processors should be referred to in written
> > text?
>
> I compared with Intels Website:
>
>   http://www.intel.com/products/browse/processor.htm?iid=ipp_nav+browse_proc&

I guess it's settled then.  If Intel calls it a Pentium III, this is
what we should call it too, IMHO.

- Giorgos

Comment 4 Giorgos Keramidas 2002-05-12 01:30:18 UTC

State Changed
From-To: open->closed

Changes partially committed.  I left out the 'recent example' part 
since this will shortly change after I make the changes Greg suggests. 
No need to increase the diffs with that part :) 

Thanks for your submission and comments. 

Comment 5 Giorgos Keramidas 2002-05-12 01:30:18 UTC

Responsible Changed
From-To: freebsd-doc->keramida