Bug 38161

Comment 1 Tom Rhodes 2002-05-17 01:34:19 UTC

State Changed
From-To: open->feedback

I cannot reproduce this error in -current or -stable, please rebuild 
your sources and let me know.  Thanks!

Comment 2 Tom Rhodes 2002-05-17 01:34:46 UTC

On Thu, 16 May 2002 17:10:58 -0700 (PDT)
Andy Farkas <andyf@speednet.com.au> wrote:

I cannot reproduce the missing ``fields'' word as you point out,
in -stable and -current.  Now, quick question.  Do you see
the .Ar fields text in the patch, that should display the word
``fields'' in an underlined form, and if you cannot see it, then
you may need to resup and rebuild.

Let me know please.

-- 
Tom (Darklogik) Rhodes
www.FreeBSD.org  -The Power To Serve
www.Pittgoth.com -Pittgoth Discussion Portal
trhodes@{Pittgoth.com, FreeBSD.org}
PGP key by www:
http://www.pittgoth.com/~darklogik/darklogik.key

> I cannot reproduce the missing ``fields'' word as you point out,
> in -stable and -current.  Now, quick question.  Do you see
> the .Ar fields text in the patch, that should display the word
> ``fields'' in an underlined form, and if you cannot see it, then
> you may need to resup and rebuild.

In the man page the description for "-s chars" reads:

  Ignore the first chars characters in each input line...

but for "-f fields" it reads:

  Ignore the first fields in each input line...

It should read:

  Ignore the first fields fields in each input line...

--

 :{ andyf@speednet.com.au

        Andy Farkas
    System Administrator
   Speednet Communications
 http://www.speednet.com.au/

Comment 4 Tom Rhodes 2002-05-17 02:17:47 UTC

On Thu, 16 May 2002 18:10:03 -0700 (PDT)
Andy Farkas <andyf@speednet.com.au> wrote:

fields fields just does not sound right when I read it though,
and I will agree that chars characters should most likly be
changed as it took around 2 reads for me to interpret it.

Anyone else care to comment?

-- 
Tom (Darklogik) Rhodes
www.FreeBSD.org  -The Power To Serve
www.Pittgoth.com -Pittgoth Discussion Portal
trhodes@{Pittgoth.com, FreeBSD.org}
PGP key by www:
http://www.pittgoth.com/~darklogik/darklogik.key

Read the second sentance in "-s chars" :)

--

 :{ andyf@speednet.com.au

        Andy Farkas
    System Administrator
   Speednet Communications
 http://www.speednet.com.au/

I think the patch is good.

Ceri

-- 
get the cool shoe shine

Comment 7 Tom Rhodes 2002-05-17 16:40:13 UTC

On Fri, 17 May 2002 00:50:03 -0700 (PDT)
Ceri Davies <setantae@submonkey.net> wrote:

>  I think the patch is good.

This is the comment I was waiting for.  Thanks Ceri ;)

>  
>  Ceri
>  
>  -- 
>  get the cool shoe shine
> 

-- 
Tom (Darklogik) Rhodes
www.FreeBSD.org  -The Power To Serve
www.Pittgoth.com -Pittgoth Discussion Portal
trhodes@{Pittgoth.com, FreeBSD.org}
PGP key by www:
http://www.pittgoth.com/~darklogik/darklogik.key

Comment 8 Giorgos Keramidas 2002-05-18 13:33:09 UTC

On 2002-05-17 11:40, Tom Rhodes wrote:
> On Fri, 17 May 2002 00:50:03 -0700 (PDT)
> Ceri Davies <setantae@submonkey.net> wrote:
> >  I think the patch is good.
>
> This is the comment I was waiting for.  Thanks Ceri ;)

For what it's worth, I don't like having two identical words, one
right after the other.  Perhaps rewording might help?  By reading the
text of uniq.1 I can see that the `fields' option of -f is actually
the number of fields that is ignored when -f is passed.  I would
really prefer this written in such a way that duplication of a word is
not needed.  Something like:

%%%
--- uniq.1.orig	Sat May 18 15:30:58 2002
+++ uniq.1	Sat May 18 15:31:14 2002
@@ -68,9 +68,9 @@
 occurred in the input, followed by a single space.
 .It Fl d
 Only output lines that are repeated in the input.
-.It Fl f Ar fields
+.It Fl f Ar num
 Ignore the first
-.Ar fields
+.Ar num
 in each input line when doing comparisons.
 A field is a string of non-blank characters separated from adjacent fields
 by blanks.
%%%

If you like this better, then you're welcome to use it, instead of the
word duplication.

- Giorgos

Comment 9 Tom Rhodes 2002-05-21 17:56:20 UTC

State Changed
From-To: feedback->patched

Slightly different patch committed to -current, MFC in 3 days and re approval. 
Thanks! 

Comment 10 Tom Rhodes 2002-05-21 17:56:20 UTC

Responsible Changed
From-To: freebsd-doc->trhodes

Slightly different patch committed to -current, MFC in 3 days and re approval. 
Thanks!

Its still missing a word; it should read:

 Ignore the first num fields in each input line when doing comparisons.
                      ^^^^^^

Also, the SYNOPSIS needs to be updated....

--

 :{ andyf@speednet.com.au

        Andy Farkas
    System Administrator
   Speednet Communications
 http://www.speednet.com.au/

Comment 12 Tom Rhodes 2002-05-29 18:01:26 UTC

State Changed
From-To: patched->closed

Rebuilt patch committed to -stable today.  Thanks for the submission!