Bug 39464

Summary: Duplicate function in /usr/src/sys/netgraph/ng_pppoe.c
Product: Base System Reporter: Greg Quinlan <gwq_uk>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description Greg Quinlan 2002-06-18 13:10:01 UTC 
/usr/src/sys/netgraph/ng_pppoe.c has a repeated function, called "send_sessionid".

Fix: 

Delete the second repeated procedure!
How-To-Repeat: compile the kernel.
Comment 1 Peter Pentchev freebsd_committer freebsd_triage 2002-06-18 16:49:17 UTC 
State Changed
From-To: open->closed


Thanks for the alert; however, there are two points that you might want 
to consider about it :) 

First, there is a mailing list specifically dealing with problems and 
peculiarities of the FreeBSD -STABLE branch: freebsd-stable@FreeBSD.org. 
If you are having a problem which seems to stem from something done to 
the -STABLE branch recently, like a commit that breaks the build, as 
opposed to some architectural change, unsupported hardware, or other 
large-scale time-consuming problem, the freebsd-stable list is the first 
place you should search for a solution, and the first place you should 
report the problem itself. 

Second, even in the cases that merit sending a GNATS PR, there is 
sometimes a lot to be gained by searching the GNATS database for others 
who have reported the same (or similar) problem.  At the URL 
http://www.FreeBSD.org/cgi?query-pr-summary.cgi?query 
there is a web interface that lets you easily search for related problem 
reports.  Right now, a search for PR's containing 'ng_pppoe' in the 
single-line fields (like the Subject or the Synopsis lines are) would 
not return many matches; however, if you check the 'closed PR's too' 
box, it will quickly become apparent that others have indeed reported 
this problem already, *and* that it has already been solved :) 

Still, thanks for your efforts in improving FreeBSD!