Bug 39920

Summary: ata(4) man pages wrongly states that only IBM DPTA and IBM DTLA support TQ
Product: Documentation Reporter: Alexey Dokuchaev <danfe>
Component: Books & ArticlesAssignee: Tom Rhodes <trhodes>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Alexey Dokuchaev 2002-06-27 12:10:01 UTC
ata(4) manual pages does not reflect that, from /usr/src/sys/dev/ata/ata-disk.c,
it is clear that not only IBM DPTA and IBM DTLA drives support tagged
queuing, but recent (obscuredly named) ICxxxxxxAT and ICxxxxxxAV drives
do that as well.  If someone, before going out and buying a drive of
those, reads the manpage, (s)he might get confused and believe that
disk of their choice does not support TQ while it, if fact, does ;-)

How-To-Repeat: man 4 ata
Comment 1 Johan Karlsson freebsd_committer freebsd_triage 2002-06-28 03:18:50 UTC
Responsible Changed
From-To: gnats-admin->freebsd-doc

Missfilled PR -> docs
Comment 2 Tom Rhodes freebsd_committer freebsd_triage 2002-07-02 21:29:12 UTC
State Changed
From-To: open->patched

I've fixed this in CURRENT, and will handle the MFC.  However, could you 
perhaps give me some more information on these drives?  Perhaps the 
model name, manufacturer name, etc.  Like: Wester Digital WD1040.  That 
information would be very helpful.  Thanks for the information! 


Comment 3 Tom Rhodes freebsd_committer freebsd_triage 2002-07-02 21:29:12 UTC
Responsible Changed
From-To: freebsd-doc->trhodes

I've fixed this in CURRENT, and will handle the MFC.  However, could you 
perhaps give me some more information on these drives?  Perhaps the 
model name, manufacturer name, etc.  Like: Wester Digital WD1040.  That 
information would be very helpful.  Thanks for the information!
Comment 4 Alexey Dokuchaev 2002-07-08 08:08:45 UTC
On Tue, Jul 02, 2002 at 01:31:41PM -0700, Tom Rhodes wrote:
> Synopsis: ata(4) man pages wrongly states that only IBM DPTA and IBM DTLA support TQ
> 
> State-Changed-From-To: open->patched
> State-Changed-By: trhodes
> State-Changed-When: Tue Jul 2 13:29:12 PDT 2002
> State-Changed-Why: 
> I've fixed this in CURRENT, and will handle the MFC.  However, could you
> perhaps give me some more information on these drives?  Perhaps the
> model name, manufacturer name, etc.  Like: Wester Digital WD1040.  That
> information would be very helpful.  Thanks for the information!

Yes, I should had stated it a bit more accurately, that is, instead of
stating model numbers like I did (ICxxxxxxAT and ICxxxxxxAV) judging
from the source code and imprinting on that brand-new 120G I bought :)
HDD family name major designation should probably be used.

As seen on IBM's website:

	http://www.storage.ibm.com/hdd/support/table.htm

This is "Deskstar" family, and ICxxxxxxAV models are only these ones:

120GXP	| IC35L120AVVA07 | 123.52G | ata100 | 7200rpm
	| IC35L100AVVA07 | 102.93G | ata100 | 7200rpm
	| IC35L080AVVA07 |  82.34G | ata100 | 7200rpm
	| IC35L060AVVA07 |  61.49G | ata100 | 7200rpm
	| IC35L040AVVA07 |  41.17G | ata100 | 7200rpm
	| IC35L020AVVA07 |  20.57G | ata100 | 7200rpm
--------+----------------+---------+--------+--------
60GXP	| IC35L060AVER07 |  61.49G | ata100 | 7200rpm
	| IC35L040AVER07 |  41.17G | ata100 | 7200rpm
	| IC35L030AVER07 |  30.73G | ata100 | 7200rpm
	| IC35L020AVER07 |  20.57G | ata100 | 7200rpm
	| IC35L010AVER07 |  10.27G | ata100 | 7200rpm

There are no other GXP models listed in their sheets.
Speaking of ICxxxxxxAV models, I believe that docs/38290 
PR originator was not as accurate as I was (as he forgot about
ICxxxxxxAT series), but his patch looks nicer (does not have all
those ugly xxxxxx thingies).

As for ICxxxxxxAT series, the family that matches this model
numbering is "Travelstar".  That's what they got:

60GH	| IC25T060ATCS05 | 60.01G | ide | 5400rpm
	| IC25T060ATCX05 | 60.01G | ide | 5400rpm
--------+----------------+--------+-----+--------
48GH	| IC25T048ATDA05 | 48.00G | ide | 5400rpm
--------+----------------+--------+-----+--------
40GN	| IC25N040ATCS04 | 40.00G | ide | 4200rpm
	| IC25N030ATCS04 | 30.00G | ide | 4200rpm
	| IC25N020ATCS04 | 20.00G | ide | 4200rpm
	| IC25N010ATCS04 | 10.05G | ide | 4200rpm
--------+----------------+--------+-----+--------
40GNX	| IC25N040ATCS05 | 40.00G | ide | 5400rpm
	| IC25N020ATCS05 | 20.00G | ide | 5400rpm
	| IC25N040ATCX05 | 40.00G | ide | 5400rpm
	| IC25N020ATCX05 | 20.00G | ide | 5400rpm
--------+----------------+--------+-----+--------
30GN	| IC25N030ATDA04 | 30.00G | ide | 4200rpm
	| IC25N020ATDA04 | 20.00G | ide | 4200rpm
--------+----------------+--------+-----+--------
15GN	| IC25N015ATDA04 | 15.00G | ide | 4200rpm
	| IC25N010ATDA04 | 10.05G | ide | 4200rpm
	| IC25N006ATDA04 | 06.00G | ide | 4200rpm

This one is a bit tougher, because we cannot simply use model main
suffix (GH, GN) like we did above with GXP models, since there are
number of GH and GN models that do not support TQ according to Soren's
code (as they do not fit ICxxxxxxAT mask):

        /*
         * check IBM's new obscure way of naming drives
         * we want "IC" (IBM CORP) and "AT" or "AV" (ATA interface)
         * but doesn't care about the other info (size, capacity etc)
         */
        if (!strncmp(adp->device->param->model, "IC", 2) &&
            (!strncmp(adp->device->param->model + 8, "AT", 2) ||
             !strncmp(adp->device->param->model + 8, "AV", 2)))
                return 1;

Frankly, I do not see a clear way of stating what drives support TQ, in
the manual page.  From one point, we could have write something like
this:

	(only IBM DPTA, DTLA, all GXP, 60GH, 48GH, 40GN, 40GNX,
	30GN, and 30GN drives support that)

OTOH, this looks obscure and somewhat inconsistent, since DPTA and DTLA
are model numbers, while GXP, 60GH, 48GH, 40GN, 40GNX, etc. are drive
family names. *sigh*

In fact, I do not see any direct indication in IBM's specs whether some
drive supports TQ or not :-(  I mean, in general.  I do not have time
for reading every *.pdf I could find there.

I'm CCing this to docs/38290, the similar PR originator, in hope that
together we can find a better solution.

AFAIK, Linux 2.5 supports TQ as well, so we might take a look how linux
folks document this. *grin*

./danfe
Comment 5 Tom Rhodes freebsd_committer freebsd_triage 2002-07-15 16:38:18 UTC
State Changed
From-To: patched->closed

Updated in -stable and -current.  Thanks for the submission!