Bug 40909

Summary: [PATCH] Typos in /usr/share/man/man4/ukbd.4.gz
Product: Documentation Reporter: Chris Pepper <pepper>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
ukbd.4.diff none

Description Chris Pepper 2002-07-23 03:40:01 UTC 
	ukbd.4 has infelicities.

Fix: Suggested patch follows.
How-To-Repeat: 	man ukbd
Comment 1 Ceri Davies freebsd_committer freebsd_triage 2002-07-23 10:02:55 UTC 
On Mon, Jul 22, 2002 at 10:36:22PM -0400, Chris Pepper said:
> 	
> >Description:
> 	ukbd.4 has infelicities.

Hi Chris,

I'm sorry but I'm not keen on any of the changes presented below -
is it possible that the patch is reversed, as each of these three
changes seems to introduce, rather than fix, grammatical error.

> -If both an AT keyboard and one or more USB keyboards are used at the same time, the
> +If both an AT keyboard as well as USB keyboards are used at the same time, the
>  AT keyboard will appear as

The original text scans better - "both" and "as well as" should probably
never appear in the same sentence.

> -From this point onwards, the first USB keyboard will be the keyboard
> -used for the console.
> +From this point on onwards, the first USB keyboard will be the keyboard
> +to be used as the console.

The change in the first line introduces an error - "on" is repeated.
The change in the second line stirs the pedant in me, since "all the
console is not a keyboard" to paraphrase a popular saying.

> -Because of the order of device
> +Because of the order of the device
>  initialization, the USB keyboard will be detected
>  .Em after
>  the console driver

"The order of device initialization" is correct here.

Sorry for seemingly jumping on this with teeth bared.

Ceri
Comment 2 dannyboy freebsd_committer freebsd_triage 2002-07-23 13:28:28 UTC 
A check in cvs reveals that this patch is indeed reversed.
Comment 3 parv 2002-07-23 22:29:23 UTC 
in message <200207230910.g6N9A7rH020574@freefall.freebsd.org>,
wrote Ceri Davies thusly...
>
> The following reply was made to PR docs/40909
...
>  - is it possible that the patch is reversed, as each of these
>  three changes seems to introduce, rather than fix, grammatical
>  error.

i agree w/ ceri fwiw.


--
Comment 4 Tom Rhodes freebsd_committer freebsd_triage 2002-08-27 17:19:22 UTC 
State Changed
From-To: open->closed

I committed a different patch than the one you submitted.  Thanks alot for 
pointing these out to us!