Bug 41034

Summary: [PATCH] Typos in /etc/named/named.conf comments
Product: Documentation Reporter: Chris Pepper <pepper>
Component: Books & ArticlesAssignee: Giorgos Keramidas <keramida>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
named.conf.diff none

Description Chris Pepper 2002-07-27 04:20:01 UTC
	The default named.conf comments are ungramattical.

Fix: Apply this patch.
How-To-Repeat: 	more /etc/named/named.conf
Comment 1 mjk 2002-07-30 05:36:23 UTC
 ... before that all gets commited :), substitute this in the relevant place above,
the only difference is an apostrophe on "it's".

@@ -16,8 +16,8 @@
 //      forward only;
 
 // If you've got a DNS server around at your upstream provider, enter
-// its IP address here, and enable the line below.  This will make you
-// benefit from its cache, thus reduce overall DNS traffic in the Internet.
+// it's IP address here, and enable the entry below.  This will let you
+// benefit from its cache, thus reducing overall DNS traffic on the Internet.
 /*
 	forwarders {
 		127.0.0.1;
Comment 2 mjk 2002-07-30 13:43:08 UTC
Please ignore my previous submission.

Dontya just love making a fool of youself in public ?
Comment 3 Giorgos Keramidas freebsd_committer freebsd_triage 2002-08-06 21:53:54 UTC
On 2002-07-30 09:51 +0000, Tom Hukins wrote:
> On Mon, Jul 29, 2002 at 09:40:04PM -0700, M.J.Kouache wrote:
> >   ... before that all gets commited :), substitute this in the relevant place above,
> >  the only difference is an apostrophe on "it's".
> >
> >  @@ -16,8 +16,8 @@
> >   //      forward only;
> >
> >   // If you've got a DNS server around at your upstream provider, enter
> >  -// its IP address here, and enable the line below.  This will make you
> >  -// benefit from its cache, thus reduce overall DNS traffic in the Internet.
> >  +// it's IP address here, and enable the entry below.  This will let you
> >  +// benefit from its cache, thus reducing overall DNS traffic on the Internet.
>
> This part of the patch is incorrect.  In the posessive form, "its" is
> the correct spelling.

The second change of the first line, s/make you/let you/ and the
second line of changes though seem like a good idea to me.  What do
you others think?

- Giorgos
Comment 4 Tom Hukins freebsd_committer freebsd_triage 2002-08-07 09:12:39 UTC
On Tue, Aug 06, 2002 at 11:53:54PM +0300, Giorgos Keramidas wrote:
> On 2002-07-30 09:51 +0000, Tom Hukins wrote:
> > On Mon, Jul 29, 2002 at 09:40:04PM -0700, M.J.Kouache wrote:
> > >
> > >  -// its IP address here, and enable the line below.  This will make you
> > >  -// benefit from its cache, thus reduce overall DNS traffic in the Internet.
> > >  +// it's IP address here, and enable the entry below.  This will let you
> > >  +// benefit from its cache, thus reducing overall DNS traffic on the Internet.
> >
> > This part of the patch is incorrect.  In the posessive form, "its" is
> > the correct spelling.
> 
> The second change of the first line, s/make you/let you/ and the
> second line of changes though seem like a good idea to me.  What do
> you others think?

Yes,  I should have been clearer: I agree with the patch apart from
the "its" to "it's" change.

Tom
Comment 5 Chris Pepper 2002-10-05 02:49:31 UTC
At 1:20 AM -0700 2002/08/07, Tom Hukins wrote:
>The following reply was made to PR docs/41034; it has been noted by GNATS.
>
>From: Tom Hukins <tom@FreeBSD.org>
>To: Giorgos Keramidas <keramida@FreeBSD.org>
>Cc: "M.J.Kouache" <mjk@rhoda.fsworld.co.uk>, bug-followup@FreeBSD.org
>Subject: Re: docs/41034: [PATCH] Typos in /etc/named/named.conf comments
>Date: Wed, 7 Aug 2002 09:12:39 +0100
>
>  On Tue, Aug 06, 2002 at 11:53:54PM +0300, Giorgos Keramidas wrote:
>  > On 2002-07-30 09:51 +0000, Tom Hukins wrote:
>  > > On Mon, Jul 29, 2002 at 09:40:04PM -0700, M.J.Kouache wrote:
>  > > >
>  > > >  -// its IP address here, and enable the line below.  This 
>will make you
>  > > >  -// benefit from its cache, thus reduce overall DNS traffic 
>in the Internet.
>  > > >  +// it's IP address here, and enable the entry below.  This 
>will let you
>  > > >  +// benefit from its cache, thus reducing overall DNS 
>traffic on the Internet.
>  > >
>  > > This part of the patch is incorrect.  In the posessive form, "its" is
>  > > the correct spelling.
>  >
>  > The second change of the first line, s/make you/let you/ and the
>  > second line of changes though seem like a good idea to me.  What do
>  > you others think?
>
>  Yes,  I should have been clearer: I agree with the patch apart from
>  the "its" to "it's" change.

Tom,

	You're right -- that's a straight error on my part.

	Somebody please apply the rest.


						Thanks,


						Chris Pepper
-- 
Chris Pepper:               <http://www.reppep.com/~pepper/>
Rockefeller University:     <http://www.rockefeller.edu/>
Comment 6 Giorgos Keramidas freebsd_committer freebsd_triage 2003-02-07 20:58:59 UTC
State Changed
From-To: open->patched

Committed all the changes except for `its -> it's' in current. 


Comment 7 Giorgos Keramidas freebsd_committer freebsd_triage 2003-02-07 20:58:59 UTC
Responsible Changed
From-To: freebsd-doc->keramida

I'll do the MFC.
Comment 8 Giorgos Keramidas freebsd_committer freebsd_triage 2003-02-13 13:23:57 UTC
State Changed
From-To: patched->closed

Merged to -STABLE.  Thank you, Chris :)