Bug 41759

Summary: Various fixes for fxp(4)
Product: Documentation Reporter: drs <drs>
Component: Books & ArticlesAssignee: Bruce A. Mah <bmah>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fxp.4.diff1
none
fxp.4.diff3 none

Description drs 2002-08-18 15:00:04 UTC 
I've found a couple of problems with the documentation for the fxp
driver.  Here are some changes to the man page; I'm about to submit a
patch for the supported hardware list.

1. Please MFC r1.21 of src/share/man/man4/fxp.4 - fxp.4.diff1 is a
   patch to do so.  The microcode loading support that it refers to
   was MFC'ed in r1.110.2.8 of src/sys/dev/fxp/if_fxp.c.

2. r1.131 of if_fxp.c added support for the i82562 chip, and it was
   MFC'ed in r1.110.2.20.  The documentation was not updated, so
   fxp.4.diff2 will do so.  It applies to -CURRENT, and should apply
   to -STABLE once the MFC mentioned above has been done.

3. Most of the newer models of Intel cards aren't mentioned. 
   fxp.4.diff3 updates the list, based on personal experience and
   http://www.intel.com/network/connectivity.  It's dependent on the
   previous patches, but should apply to both -CURRENT and -STABLE.

4. All of Intel's docs call the cards "PRO/100", but all of the
   FreeBSD docs and source call them "Pro/100".  Is it worth fixing?

Fix: --- src/share/man/man4/fxp.4.1	Sun Aug 18 14:42:18 2002
+++ src/share/man/man4/fxp.4	Sun Aug 18 14:43:25 2002
@@ -39,7 +39,7 @@
 .Nm
 driver provides support for the EtherExpress Pro/10, Pro/100B, and Pro/100+
 PCI Fast Ethernet adapters based on the Intel i82557, i82558, i82559 
-or i82550 ethernet chips.
+i82550, or i82562 ethernet chips.
 .Pp
 The
 .Nm
--- fxp.4.diff2 ends here ---
Comment 1 Bruce A. Mah freebsd_committer freebsd_triage 2002-08-21 16:40:46 UTC 
Responsible Changed
From-To: freebsd-doc->bmah

Related to docs/41760, which I just grabbed, so I'll take this one too.
Comment 2 Bruce A. Mah freebsd_committer freebsd_triage 2002-08-24 18:02:53 UTC 
State Changed
From-To: open->closed

I committed a variant of your patches to -CURRENT and 4-STABLE. 

For future reference, the microcode patch for 4-STABLE didn't yield 
the same text as on -CURRENT.  We also try to put a newline immediately 
after the full-stop that ends a sentence, and trailing whitespace at  
the end of a line is a no-no as it sometimes makes groff do some odd 
things. 

Thanks for the diffs!
Comment 3 drs 2002-08-24 19:01:11 UTC 
On Sat 2002-08-24 (10:06), Bruce A. Mah wrote:
> Synopsis: Various fixes for fxp(4)
> 
> State-Changed-From-To: open->closed
> State-Changed-By: bmah
> State-Changed-When: Sat Aug 24 10:02:53 PDT 2002
> State-Changed-Why: 
> I committed a variant of your patches to -CURRENT and 4-STABLE.
> 
> For future reference, the microcode patch for 4-STABLE didn't yield
> the same text as on -CURRENT.  We also try to put a newline immediately
> after the full-stop that ends a sentence, and trailing whitespace at 
> the end of a line is a no-no as it sometimes makes groff do some odd
> things.
> 
> Thanks for the diffs!
> 
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=41759

It looks as if you've committed the new chips, but not the new card
names.  (Apologies if the way I split the diffs up made it
confusing.)


-- 
David Siebörger
drs@rucus.ru.ac.za
Comment 4 Bruce A. Mah freebsd_committer freebsd_triage 2002-08-24 23:28:00 UTC 
If memory serves me right, David =?iso-8859-1?Q?Sieb=F6rger?= wrote:

> It looks as if you've committed the new chips, but not the new card
> names.  (Apologies if the way I split the diffs up made it
> confusing.)

My fault, sorry about that.  I think I got it right now.

Thanks!

Bruce.